-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
Thanks Varun. In general this is looking good. I'm going to leave some more comments in a bit. The one thing that is a bit tricky here is that the dataset processing is it a bit too tied into the server benchmarking, which makes it a bit tricky to support swapping in and out the datasets we are benchmarking (which we will do over time). For example, we will want a different request pattern for prefix caching performance benchmarking than general I'm going to put up a PR with an idea for how to make this a bit more pluggable |
Thanks @robertgshaw2-neuralmagic
I made a recent refactor that moves the dataset related stuff into |
493d4a1
to
2646860
Compare
I completely hacked the relative import system to do a simple proof of concept of how the Idea was to have a programatic way to add new datasets. Thus, the
This should make it easy to add new datasets over time. |
c887ae5
to
a86a0bf
Compare
3b58cab
to
a86a0bf
Compare
@@ -0,0 +1,178 @@ | |||
""" | |||
Common functions used in all benchmarking scripts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we want to point out these are for our benchmarking scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we are going down this rabbit whole again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the "meetup". looks good.
Summary:
Add benchmarking scripts and utils.
Things to note :
neuralmagic
folder.Testing:
Local testing