Generate tarball along with wheel build, and upload both in a package to GH #138
Conversation
dhuangnm
requested review from
mgoin,
varun-sundar-rabindranath,
bnellnm,
robertgshaw2-redhat and
andy-neuma
| ls -alh dist/ | ||
| BASE=$(./.github/scripts/convert-version ${{ inputs.python }}) | ||
| WHL_FILEPATH=$(find dist -iname "*nm_vllm*${BASE}*.whl") | ||
| WHL=$(basename ${WHL_FILEPATH}) | ||
| echo "whl=${WHL}" >> "$GITHUB_OUTPUT" | ||
| # generate .tar.gz | ||
| $SUCCESS || python3 setup.py sdist || SUCCESS=$? |
There was a problem hiding this comment.
Hey Dan. The $SUCCESS || in $SUCCESS || python3 setup.py sdist || SUCCESS=$? isn't doing what is intended. I see
/opt/actions-runner/_work/_temp/68fcf277-8944-46d0-8362-4c8020852b3b.sh: line 12: 0: command not found
in https://github.com/neuralmagic/nm-vllm/actions/runs/8359879522/job/22884186408
I think it is safe to remove.
There was a problem hiding this comment.
Hi Varun, the $SUCCESS in
There was a problem hiding this comment.
Updated command so it'll work as intended, good catch.
| ls -alh dist/ | ||
| BASE=$(./.github/scripts/convert-version ${{ inputs.python }}) | ||
| WHL_FILEPATH=$(find dist -iname "*nm_vllm*${BASE}*.whl") | ||
| WHL=$(basename ${WHL_FILEPATH}) | ||
| echo "whl=${WHL}" >> "$GITHUB_OUTPUT" | ||
| # generate .tar.gz | ||
| $SUCCESS || python3 setup.py sdist || SUCCESS=$? | ||
| ls -alh dist/ |
There was a problem hiding this comment.
Not sure if this is intentional. Using the same dist folder includes the wheel in the tarball. May be use a different directory if it isn't intentional ? @mgoin
There was a problem hiding this comment.
The sdist argument is to generate source distribution, i.e. the tar.gz file. It'll be generated under the same folder as the wheel which is generated in an earlier step, i.e. dist/. This is the default output folder for generated packages. We want to keep them under dist/ since we'll upload them both to GH in one step by just providing the dist/ path to an upload action.
A run will look like this:
https://github.com/neuralmagic/nm-vllm/actions/runs/8359879522