This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
Fixed bug, caused by boolean typo in ObjectPool.StartShrinkTimer.
#248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just renamed `disposedValue` to `isDisposed` for clarity and inverted check in `TakeWhile` calls.
joshua-light
changed the title
ObjectPool.StartShrinkTimer.ObjectPool.StartShrinkTimer.
|
thanks! |
EarMaster
pushed a commit
to EarMaster/UniRx
that referenced
this pull request
Jun 12, 2019
…ewhile-fix Fixed bug, caused by boolean typo in `ObjectPool.StartShrinkTimer`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again!
So, as mentioned in issue #217, there is a little bug with check in
TakeWhilecall.disposedValuemeans: if object is already disposed or not, so we should take while object is not disposed.I've done two things:
disposedValuetoisDisposedfor the sake of clarity.