Skip to content
This repository has been archived by the owner on Feb 14, 2020. It is now read-only.

ndt.go: send at least one MSG_RESULT back #18

Merged
merged 1 commit into from
Jan 7, 2017
Merged

Commits on Jan 7, 2017

  1. ndt.go: send at least one MSG_RESULT back

    The [specification](https://github.com/ndt-project/ndt/wiki/NDTProtocol)
    doesn't explicitly state that the server MUST send to the client
    at least one MSG_RESULT message. But, looking into the sequence
    diagram that is part of the specification, this is CLEARLY implied.
    
    As such, botticelli was broken because it was violating the protocol.
    
    The proper fix would be to read Web100 variables, compute a number
    of metrics and send those back to the client. But, botticelli has
    not reached this point of maturity yet.
    
    As a fix, I implemented sending back a single variable formatted as
    the NDT code would expect, so that it does not crash, but named using
    a clearly nonstandard name such that it's not used.
    
    Bug reported by @nkinkade, thanks!
    bassosimone committed Jan 7, 2017
    Configuration menu
    Copy the full SHA
    9996406 View commit details
    Browse the repository at this point in the history