Fix bug with silent comment nesting #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser was incorrectly killing blocks of code that were at the same level as a silent comment if the silent comment was nested below the line before it.
|
Doesn't seem to work on 0.10 ? Not sure if it's travis' fault since nothing shows up. Thanks for your contribution tho |
|
I meant node. But it looks like it passed now :). LGTM ! |
|
Thanks a lot! ❤️ |
|
you're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser was incorrectly killing blocks of code that were at the same
level as a silent comment if the silent comment was nested below the line
before it. Added a test case that was failing on master.