Added placement option to allow for AMD support #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
template function in a define block instead of placing it inside `window.HAML`.
|
This looks very nice. There are currently no unit tests for Haml Coffee (shame on me), only template integration tests, so there's nothing missing. Thanks a lot. I'm currently short on time at the end of my holiday, but I'll take some time on Tuesday to give it a try, merge and release. |
|
Version 1.6.0 has been released with your AMD support. Thanks a lot! |
|
Not a problem; glad I could be of help. Thank you (and all the contributors of course) for this coffee-powered haml implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
placementoption to rendering that when set to 'amd' places compiled function in adefine()block to allow for AMD loading.If there is anything else I need to do to get this merged (tests, more docs, forgot somewhere that render is called), let me know.