Better source_map support #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 21, 2013 19:06
When CoffeeScript.compile is normally called, the result is a string containing the compiled js. When sourceMap is set to true though, the result is a hash with keys ['js', 'sourceMap', 'v3SourceMap']. Before this change, we'd write that entire hash into the .map file, and I'm somewhat sure that isn't a valid sourceMap.
The coffeescript compiler accepts various file and path options to help the browser find the original source files that the map refers to. sourceFiles - name of the original sources. sourceRoot - Root url the browser prepends to all sourceFiles. It's useful to override this if you want to change where/how these files are served, like adding authentication. generatedFile - I'm actually not sure why this is necessary, since the generated file itself should refer to the map. I added in an effort to closely match the output of the coffee binary.
The comment tells the browser where to download the source map. It's also possible to inform the browser using an HTTP header, but the comment is better by default, because things will work right out of the box.
|
Thanks a lot. Version 1.3.1 is released. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits try to get source maps working correctly.
I believe the map generated before wasn't valid, and lacked a bunch of the attributes the browser needs to correctly show the original source.