-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Ecoflow River3+ and Delta3+ support #2740
base: master
Are you sure you want to change the base?
Conversation
Basic status works (charging, discharging, online, onbattery, ...). Charge level works. Discharge level from app shows correctly. Any sort of control does not seem to work for load or beeper/light. See code comments for details. Signed-off-by: Yevgeniy Kuksenko <2882631+ykuksenko@users.noreply.github.com>
Thanks for getting the ball rolling on this! I only recently found out that Ecoflow is planning to support its Power Manager software for both the River 3 and Delta 3 series of portable batteries, though the Delta 3 seems delayed until "end of February" according to the page I linked to above. I've got a Synology DS918+ currently powered by a Delta 3 Plus that I'd be happy to test with, if necessary. I'd just need to dig out a USB-C to USB-A cable (unless perhaps they're supporting SNMP-based UPS HID?), and receive some instruction on modifying Synology's DSM via SSH, if that's what it takes. Either way, I'ma subscribe to see where this leads, as it'd be super cool to program our NAS hardware to gracefully shutdown once an Ecoflow battery reaches whatever low-capacity threshold we specify. |
networkupstools#2735, PRs networkupstools#2740, networkupstools#2837] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
… added [issue networkupstools#2735, PRs networkupstools#2740, networkupstools#2837] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…dd (C) of contributors [issue networkupstools#2735, PRs networkupstools#2740, networkupstools#2837] Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…etworkupstools#2740, networkupstools#2837] * import back comments about findings in PR networkupstools#2740, * apply reasonable number precision and HU_FLAG* where two codebases differed, * clean up "unmapped.*" entries that are actually exposed as standard or experimental data points, or in some cases drop the "experimental.*" ones (it is easy to build code with settings which would show the same values as "unmapped.*") Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
This PR source was assimilated into #2837, thanks for the extensive comments about investigation results! |
Attempting to add EcoFlow support in response to #2735. Specifically Delta 3 Plus and River 3 Plus models.
Working:
Not working:
Model differences:
Attribute Details/Questions:
HU_FLAG_QUICK_POLL
flag be used? The boolean values all seem to be alarm and status related. Does this look okay?DesignCapacity
andFullChargeCapacity
metrics seem to be percent. Are the mappings okay to use despite NUT docs wanting these in Ah?flow.[4].configactivepower
attribute is close to unit Wh ratings. It matches on Delta 3+ but is not correct for River 3+. What should Wh metrics be mapped to if anything? Maybe use to calculate/estimateDesignCapacity
/FullChargeCapacity
.RemainingCapacityLimit
attribute shows the percentage at which the load will be turned off. Is this okay to map tobattery.low
? It is definitely a useful thing to have, just not sure if with that mapping.RunTimeToEmpty
does not takeRemainingCapacityLimit
in to account. How should the user be informed of this? The unit is in minutes, does this need to be converted to seconds or can it be left as is?General points
Described the changes in the PR submission or a separate issue, e.g.
known published or discovered protocols, applicable hardware (expected
compatible and actually tested/developed against), limitations, etc.
There may be multiple commits in the PR, aligned and commented with
a functional change. Notably, coding style changes better belong in a
separate PR, but certainly in a dedicated commit to simplify reviews
of "real" changes in the other commits. Similarly for typo fixes in
comments or text documents.
Please star NUT on GitHub, this helps with sponsorships! ;)
Frequent "underwater rocks" for driver addition/update PRs
Revised existing driver families and added a sub-driver if applicable
(
nutdrv_qx
,usbhid-ups
...) or added a brand new driver in the othercase.
Did not extend obsoleted drivers with new hardware support features(notably
blazer
and other single-device family drivers for Qx protocols,except the new
nutdrv_qx
which should cover them all).For updated existing device drivers, bumped theDRIVER_VERSION
macroor its equivalent.
For USB devices (HID or not), revised that the driver uses unique
VID/PID combinations, or raised discussions when this is not the case
(several vendors do use same interface chips for unrelated protocols).
For new USB devices, built and committed the changes for the
scripts/upower/95-upower-hid.hwdb
fileProposed NUT data mapping is aligned with existing
docs/nut-names.txt
file. If the device exposes useful data points not listed in the file, the
experimental.*
namespace can be used as documented there, and discussionshould be raised on the NUT Developers mailing list to standardize the new
concept.
Updated
data/driver.list.in
if applicable (new tested device info)Frequent "underwater rocks" for general C code PRs
structure layout and alignment in memory, endianness (layout of bytes and
bits in memory for multi-byte numeric types), or use of generic
int
wherelanguage or libraries dictate the use of
size_t
(orssize_t
sometimes).Progress and errors are handled with
upsdebugx()
,upslogx()
,fatalx()
and related methods, not with directprintf()
orexit()
.Similarly, NUT helpers are used for error-checked memory allocation and
string operations (except where customized error handling is needed,
such as unlocking device ports, etc.)
Coding style (including whitespace for indentations) follows precedent
in the code of the file, and examples/guide in
docs/developers.txt
file.For newly added files, the
Makefile.am
recipes were updated and themake distcheck
target passes.General documentation updates
Updateddocs/acknowledgements.txt
(for vendor-backed device support)Added or updated manual page information in
docs/man/*.txt
filesand corresponding recipe lists in
docs/man/Makefile.am
for new pagesPassed
make spellcheck
, updated spell-checking dictionary in thedocs/nut.dict
file if needed (did not remove any words -- themake
rule printout in case of changes suggests how to maintain it).
Additional work may be needed after posting this PR
Propose a PR for NUT DDL with detailed device data dumps from tests
against real hardware (the more models, the better).
Address NUT CI farm build failures for the PR: testing on numerous
platforms and toolkits can expose issues not seen on just one system.
the changed codebase.
LGTM.COM looks to be shutdown as of Dec 16 (2022?).*