Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to "battery.mfr.date" (cps-hid, powercom-hid) #1645

Merged
merged 4 commits into from
Sep 20, 2022

Conversation

jimklimov
Copy link
Member

@jimklimov jimklimov commented Sep 2, 2022

  • CPS: If data is served at a better USB HID report, use that (for most devices it is not served however)
  • Powercom: Use correct NUT item name for the battery.mfr.date (if known)

Closes: #437
Closes: #1644

@jimklimov jimklimov requested review from aquette and clepple September 2, 2022 10:30
@jimklimov jimklimov added the need testing Code looks reasonable, but the feature would better be tested against hardware or OSes label Sep 5, 2022
@jimklimov jimklimov merged commit 692bad9 into networkupstools:master Sep 20, 2022
@jimklimov jimklimov deleted the issue-437 branch September 20, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug need testing Code looks reasonable, but the feature would better be tested against hardware or OSes USB
Projects
None yet
1 participant