Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new template show port-security interface #885

Merged
merged 11 commits into from
Mar 15, 2021

Conversation

jeffkala
Copy link
Contributor

ISSUE TYPE
  • New Template Pull Request
COMPONENT

cisco_ios_show_port-security_interface.textfsm, cisco_ios, show port-security interface interface

SUMMARY

New template to parse the output of show port-security interface command.


@jmcgill298
Copy link
Contributor

@jeffkala Unfortunately this PR wasn't passing tests last night when we migrated to poetry. Poetry does not allow us to package files outside of the package directory, so templates have moved to ntc-templates/templates. This branch will need to be rebased against master to fix the conflicts

@jeffkala
Copy link
Contributor Author

No problem @jmcgill298 , I have a few fixes to the template I need to do anyways.

Copy link
Contributor

@FragmentedPacket FragmentedPacket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change for it to work to the index file and then revert the permissions on the development_script.py

@FragmentedPacket FragmentedPacket added the changes_requested Waiting on user to address feedback label Mar 13, 2021
jeffkala and others added 3 commits March 15, 2021 10:27
@jeffkala
Copy link
Contributor Author

@FragmentedPacket , I did accept your suggestion, but not sure its accurate for my case. Obviously I'm haivng some issues figuring it out myself. The actual command would be show port-security interface <interface name>. Last week when I talked to @jmcgill298 he helped me fix my test where I needed to change my folder name to .._interface_interface. So i'm pretty confident my index file for this one needs to end with a regex to match the actual interface name?

@FragmentedPacket
Copy link
Contributor

That's fair. I'm not entirely sure, but when I messed with it, I couldn't get it working with the way it was originally setup with the RegEx in the index file. You can revert it and maybe hit up @jmcgill298 to see the way to do it. I'd be interested to see how to get it working as well.

@jeffkala
Copy link
Contributor Author

jeffkala commented Mar 15, 2021

I put it back to the last regex I got working locally. Just needed to update the actual template name with _interface to. Believe everthing is working now.

@FragmentedPacket
Copy link
Contributor

👍 Awesome! That makes more sense now that the template has _interface at the end of it.

Do you mind just doing chmod 755 development_scripts.py to set it back to the original permissions?

@jeffkala
Copy link
Contributor Author

👍 Awesome! That makes more sense now that the template has _interface at the end of it.

Do you mind just doing chmod 755 development_scripts.py to set it back to the original permissions?

Done, sorry about that.

@jmcgill298 jmcgill298 merged commit 5e56aaa into networktocode:master Mar 15, 2021
@jmcgill298
Copy link
Contributor

Thanks @jeffkala

guillaume-mbali pushed a commit to unyc-io/ntc-templates that referenced this pull request Apr 12, 2023
cppmonkey pushed a commit to cppmonkey/ntc-templates that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants