#784-cisco_asa_show_running-config_all_crypto_map.textfsm #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add raw and test, split var SA into SA_SEC, SA_KB match new TFC_PACKETS fix isakmp_dynamic match
diepes
requested review from
FragmentedPacket,
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
diepes
commented
Mar 10, 2021
...sco_asa/show_running-config_all_crypto_map/cisco_asa_show_running-config_all_crypto_map2.yml
Show resolved
Hide resolved
jmcgill298
approved these changes
Mar 11, 2021
This was referenced Mar 14, 2021
Closed
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
guillaume-mbali
pushed a commit
to unyc-io/ntc-templates
that referenced
this pull request
Apr 12, 2023
cppmonkey
pushed a commit
to cppmonkey/ntc-templates
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add raw and test,
split var SA into SA_SEC, SA_KB
match new TFC_PACKETS
fix isakmp_dynamic match
ISSUE TYPE
COMPONENT
cisco_asa_show_running-config_all_crypto_map
(Fix for New template in same Issue784, requester provided new raw/test )
SUMMARY
Current test updated, the template was created for Issue #784, this PR includes additional raw sample provided in #784 for further corner cases where SA (Security Association) can have KB limit in addition to Seconds.
Breaking: Split var SA into SA_SEC and SA_KB
Make crypto map block detection more reliable by using non capture match with "-> Continue.Record"
Fix bug where single entry got lumped with following block.
From tests/.../cisco_asa_show_running-config_all_crypto_map.raw
crypto map WAN1_CMAP 65535 ipsec-isakmp dynamic SYSTEM_DEFAULT_CRYPTO_MAPafter fix the line above results in own block.