Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes#811 arista eos show ip route #843

Merged

Conversation

diepes
Copy link
Contributor

@diepes diepes commented Dec 9, 2020

ISSUE TYPE
  • Bugfix Pull Request
  • Additional Testing
COMPONENT

arista_eos_show_ip_route

SUMMARY
  1. handle tunnel interface in nexthop
  2. Change nexthop IP/Int into a list.

before

    next_hop: "connected"
    interface: "Vlan105"

after

    next_hop:
      - "connected"
    interface:
      - "Vlan105"

Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @diepes I personally like this approach better, but it will be more difficult for users to consume. What do you think @FragmentedPacket @jvanderaa ?

@FragmentedPacket
Copy link
Contributor

I like this approach as well. I believe we've converted a few templates to this as well for ECMP related routes.

@jvanderaa
Copy link
Contributor

It's not clear to me why the change to a list of items instead of just the value of the key being the text. I'm assuming that there is the possibility of multiple routes then? I'm not going to hold this up, but we should get an example of this into the tests as well to verify that it is handled.

Also, would this cause us to go to 2.x for the templates with the change?

@jmcgill298
Copy link
Contributor

@jvanderaa It is for multiple paths in the routing table, and the existing test cases have been updated and include scenarios for this scenario.

@jmcgill298 jmcgill298 merged commit 255b929 into networktocode:master Feb 27, 2021
jvanderaa pushed a commit that referenced this pull request Nov 10, 2021
guillaume-mbali pushed a commit to unyc-io/ntc-templates that referenced this pull request Apr 12, 2023
cppmonkey pushed a commit to cppmonkey/ntc-templates that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants