-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes#811 arista eos show ip route #843
Fixes#811 arista eos show ip route #843
Conversation
nexthop interface and ip to list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @diepes I personally like this approach better, but it will be more difficult for users to consume. What do you think @FragmentedPacket @jvanderaa ?
I like this approach as well. I believe we've converted a few templates to this as well for ECMP related routes. |
It's not clear to me why the change to a list of items instead of just the value of the key being the text. I'm assuming that there is the possibility of multiple routes then? I'm not going to hold this up, but we should get an example of this into the tests as well to verify that it is handled. Also, would this cause us to go to 2.x for the templates with the change? |
@jvanderaa It is for multiple paths in the routing table, and the existing test cases have been updated and include scenarios for this scenario. |
ISSUE TYPE
COMPONENT
arista_eos_show_ip_route
SUMMARY
before
after