New template: dell_powerconnect #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 20, 2020 13:42
- show_interfaces_description - show_interfaces_status - show_bridge_address_table
|
Hmm, weird travis issues, can you make a benign commit to kick off travis again? Normally as an admin I could kick it off, but I can't seem to get it to work in this case. |
|
Hi, @itdependsnetworks. |
jmcgill298
requested changes
Dec 1, 2020
There was a problem hiding this comment.
Thanks @nidebr
Two of the templates need to add catching for unmatched lines, and I had a question about one match line.
templates/dell_powerconnect_show_interfaces_description.textfsm
Outdated
Show resolved
Hide resolved
templates/dell_powerconnect_show_interfaces_description.textfsm
Outdated
Show resolved
Hide resolved
templates/dell_powerconnect_show_interfaces_description.textfsm
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>
Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>
|
Thanks @nidebr another PR was merged that caused a conflict, so I have resolved that and should be good to merge once travis completes |
jmcgill298
approved these changes
Dec 1, 2020
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
guillaume-mbali
pushed a commit
to unyc-io/ntc-templates
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
ISSUE TYPE
New Template Pull Request
COMPONENT
SUMMARY
add some templates for dell_powerconnect
BR
Nick