-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cisco_nxos show version - extract serial from "Processor board ID" #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrape SERIAL form show ver, end on -> Error, match all junk in between.
FragmentedPacket
suggested changes
Oct 12, 2020
remove extra space at end of capabilities match
enable ^.+ -> Error match
add match for vrf <> to be parsed by same template
add test case for new index match + vrf all
revert IOS XE match but leave SERIAL
revert more of the unneccesary changes leaving only uptime.
add missing newline at end of file
jmcgill298
requested changes
Nov 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of issues on matching space characters. Thanks!
accept review suggestion, match multiple spaces not just one. Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>
match multiple spaces not just one. Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>
jmcgill298
approved these changes
Nov 18, 2020
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
guillaume-mbali
pushed a commit
to unyc-io/ntc-templates
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
templates/cisco_nxos_show_version.textfsm
SUMMARY