Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cisco_nxos show version - extract serial from "Processor board ID" #813

Merged
merged 15 commits into from
Nov 18, 2020

Conversation

diepes
Copy link
Contributor

@diepes diepes commented Oct 8, 2020

ISSUE TYPE
  • Bugfix Pull Request
  • Additional Testing
COMPONENT

templates/cisco_nxos_show_version.textfsm

SUMMARY
  1. extract serial# from show version (Also for existing 3 raw files, and added 4th with different syntax)
  2. end on -> Error
  3. match additional stack switch serial, and add to list.

@FragmentedPacket FragmentedPacket added the changes_requested Waiting on user to address feedback label Oct 12, 2020
Pieter E Smit added 10 commits October 23, 2020 18:30
remove extra space at end of capabilities match
add match for vrf <> to be parsed by same template
add test case for new index match + vrf all
revert IOS XE match but leave SERIAL
revert more of the unneccesary changes leaving only uptime.
add missing newline at end of file
Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of issues on matching space characters. Thanks!

templates/cisco_nxos_show_cdp_neighbors_detail.textfsm Outdated Show resolved Hide resolved
templates/cisco_ios_show_ip_eigrp_neighbors.textfsm Outdated Show resolved Hide resolved
diepes and others added 2 commits November 16, 2020 20:44
accept review suggestion, match multiple spaces not just one.

Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>
match multiple spaces not just one.

Co-authored-by: Jacob McGill <9847006+jmcgill298@users.noreply.github.com>
@jmcgill298 jmcgill298 merged commit 84e220b into networktocode:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants