New Template - hp_procurve_show_interfaces #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, has anyone been able to review my commits yet? Please can you advise if any amendments need to be made. This is my first pull request on GitHub. :-) Thanks |
jmcgill298
requested changes
Oct 20, 2020
|
Thanks for the reply Jacob. I have corrected the order for my template within the index file and have committed the change for merging.
I have rebased my repo and the test that was previously failing has passed.
Thanks
Adeel
…Sent from my iPhone
On 20 Oct 2020, at 23:11, Jacob McGill <notifications@github.com> wrote:
Thanks Adraf82. The tests are failing, but I believe that if you rebase this with the current master, then they will likely pass. Please let us know if you need help with rebasing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#796 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANIVDFYA2ZR3W4ALHRKBW2LSLYDJBANCNFSM4QNNGBOA>.
|
jmcgill298
approved these changes
Oct 21, 2020
|
Thanks @adraf82 |
thomasblass
pushed a commit
to thomasblass/ntc-templates
that referenced
this pull request
Oct 25, 2020
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
guillaume-mbali
pushed a commit
to unyc-io/ntc-templates
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
hp_procurve_show_interfaces.textfsm
SUMMARY
I have added a new template for the 'show interfaces' command for a hp procurve device.