New Template: juniper_junos_show_lacp_interfaces #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FragmentedPacket
suggested changes
May 21, 2020
| Start | ||
| ^Aggre -> Continue.Record | ||
| ^Aggregated\sinterface:\s${AGGREGATED_INTERFACE}(\s|$$) -> Continue | ||
| ^\s+${MEMBER_INTERFACE}\s+${RECEIVE_STATE}\s+${TRANSMIT_STATE}\s+${MUX_STATE}(\s|$$) -> Continue |
There was a problem hiding this comment.
Do you mind restructuring this template a bit?
I think it may be good to act off the headers within the output for both the LACP state and LACP protocol.
Something like:
Value Required,Filldown AGGREGATED_INTERFACE (\S+)
Value List MEMBER_INTERFACE (\S+)
Value List RECEIVE_STATE (\S+\s?\w+)
Value List TRANSMIT_STATE (\S+\s?periodic)
Value List MUX_STATE (\S+\s?\S*)
Start
^Aggregated -> Continue.Record
^Aggregated\sinterface:\s${AGGREGATED_INTERFACE}(\s|$$) -> Continue
^LACP\s+state
^\s+\S+
^LACP\s+protocol -> LACP_PROTO
^\s*$$
^. -> Error
LACP_PROTO
^\s+${MEMBER_INTERFACE}\s+${RECEIVE_STATE}\s+${TRANSMIT_STATE}\s+${MUX_STATE}(\s|$$) -> Continue
^Aggregated -> Start
^\s*$$
^. -> Error
There was a problem hiding this comment.
Thank you for the good suggestions.
I added LACP protocol header in the template.
Start
^Aggregated -> Continue.Record
^Aggregated\sinterface:\s${AGGREGATED_INTERFACE}(\s|$$) -> Continue
^\s+LACP\s+state: -> Continue
^\s+LACP\sprotocol: -> LACP_PROTO
^\s*$$
^{master:\d+}
LACP_PROTO
^\s+${MEMBER_INTERFACE}\s+${RECEIVE_STATE}\s+${TRANSMIT_STATE}\s+${MUX_STATE}(\s|$$) -> Continue
^\s*$$
^Aggregated -> Continue.Record
^Aggregated\sinterface:\s${AGGREGATED_INTERFACE}(\s|$$) -> Start
FragmentedPacket
approved these changes
May 24, 2020
thomasblass
pushed a commit
to thomasblass/ntc-templates
that referenced
this pull request
Oct 25, 2020
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
guillaume-mbali
pushed a commit
to unyc-io/ntc-templates
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
SUMMARY
This template can parse show lacp interfaces on juniper devices.