Ciena SAOS templates (naming fix)

[georgesnow]

ISSUE TYPE

• Updated Template Pull Request
• Bugfix Pull Request - Ciena naming fix Ciena naming doesn’t conform to Netmiko #662

COMPONENT

ciena_saos (old was ciena_6x)

SUMMARY

this adds new templates for Ciena SAOS. I have tested all of these against Ciena devices using Nornir/Netmiko and they all work. I opened as draft pull request until the tests issue is resolved, but all the templates are working didn't want someone else duplicate the effort.

However, I tried updating to the correct naming convention in the tests. This has produced few errors that need to be resolve. If you have ideas please let me know

Output:

======================================= FAILURES =======================================
_________________________________ test_index_ordering __________________________________

    def test_index_ordering():

        os_choices = [
            "a10",
            "alcatel_aos",
            "alcatel_sros",
            "arista_eos",
            "aruba_os",
            "avaya_ers",
            "avaya_vsp",
            "brocade_fastiron",
            "brocade_netiron",
            "brocade_nos",
            "brocade_vdx",
            "brocade_vyos",
            "checkpoint_gaia",
            "ciena_saos",
            "cisco_asa",
            "cisco_ios",
            "cisco_nxos",
            "cisco_s300",
            "cisco_wlc",
            "cisco_xe",
            "cisco_xr",
            "dell_force10",
            "enterasys",
            "extreme",
            "f5_ltm",
            "fortinet_fortios",
            "hp_comware",
            "hp_procurve",
            "huawei_vrp",
            "juniper",
            "juniper_junos",
            "juniper_screenos",
            "linux",
            "ovs_linux",
            "paloalto_panos",
            "quanta_mesh",
            "ruckus_fastiron",
            "ubiquiti_edgeswitch",
            "vmware_nsxv",
            "vyatta_vyos",
            "vyos",
            "watchguard_firebox",
        ]

        prior_os = ""
        prior_len = 0
        prior_cmd = ""
        used_os = []

        index = load_index_data()
        for row in index:
            template = row[0].strip()
            os = "_".join(template.split("_")[:2])
            cmd = "_".join(template.split("_")[2:])
            cmd_len = len(cmd)
            check_val, check_msg = check_order(
                os, prior_os, cmd_len, prior_len, os_choices, used_os, cmd, prior_cmd
            )
            if not check_val:
                # assertFalse(check_val, msg=check_msg)
                print("Error on line: {0}".format(row))
                print("Error Message: {0}".format(check_msg))
>           assert check_val
E           assert False

tests/test_index_order.py:127: AssertionError
--------------------------------- Captured stdout call ---------------------------------
Error on line: ['ciena_saos_software_show.textfsm', ' .*', ' ciena_saos', ' so[[ftware]] sh[[ow]]']
Error Message: Current Command len '21' larger then previous '17', for command 'software_show.textfsm'

[jmcgill298]

Update Tox to allow for various python versions

[georgesnow]

one issue is I didn't realize I need the yml file to account for all returned records. I will have to fix that next week.