Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for cisco_ios_show_redundancy #651

Closed
wants to merge 8 commits into from

Conversation

dhanasekaar
Copy link

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT

cisco_ios_show_redundancy

SUMMARY

Bug Fix


@dhanasekaar dhanasekaar changed the title Add files via upload bug fix for cisco_ios_show_redundancy Apr 15, 2020
Comment on lines -1 to -38
Redundant System Information :
------------------------------
Available system uptime = 2 days, 2 hours, 39 minutes
Switchovers system experienced = 0
Standby failures = 0
Last switchover reason = none

Hardware Mode = Duplex
Configured Redundancy Mode = Stateful Switchover
Operating Redundancy Mode = Stateful Switchover
Maintenance Mode = Disabled
Communications = Up

Current Processor Information :
-------------------------------
Active Location = slot 1
Current Software state = ACTIVE
Uptime in current state = 2 days, 2 hours, 39 minutes
Image Version = Cisco Internetwork Operating System Software
IOS (tm) Catalyst 4000 L3 Switch Software (cat4000-I5S-M), Version 12.2(20)EWA(3
.92), CISCO INTERNAL USE ONLY ENHANCED PRODUCTION VERSION
Copyright (c) 1986-2004 by cisco Systems, Inc.
Compiled Wed 14-Jul-04 04:42 by esi
BOOT = bootflash:cat4000-i5s-mz.122_20_EWA_392,1
Configuration register = 0x2002

Peer Processor Information :
----------------------------
Standby Location = slot 2
Current Software state = STANDBY HOT
Uptime in current state = 2 days, 2 hours, 39 minutes
Image Version = Cisco Internetwork Operating System Software
IOS (tm) Catalyst 4000 L3 Switch Software (cat4000-I5S-M), Version 12.2(20)EWA(3
.92), CISCO INTERNAL USE ONLY ENHANCED PRODUCTION VERSION
Copyright (c) 1986-2004 by cisco Systems, Inc.
Compiled Wed 14-Jul-04 0
BOOT = bootflash:cat4000-i5s-mz.122_20_EWA_392,1
Configuration register = 0x2002
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uploaded same data again

@@ -1,82 +1,91 @@
Value SYSTEM_UPTIME_DAYS (\d+)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind fixing the files that remove & replace? This makes it hard to see what actually changed and bound to miss something when reviewing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Fields as optional - System uptime years, System uptime weeks, Active uptime years, Active uptime weeks, standby uptime years, Standby uptime weeks
Updated peer failed status on line 73. my first push let me know if you have questions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is your OS you're editing in?

The line endings are what replacing all these files. If you're running linux, you can install dos2unix and run it against the files that are completely replaced rather than just showing your changes you made.

If you need help, I'm on our NTC public Slack as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running on windows

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think Windows is hijacking the line endings and causing this issue.

I will create a new PR that shows the actual changes and then tag you in it for these changes.

@FragmentedPacket FragmentedPacket added the changes_requested Waiting on user to address feedback label Apr 15, 2020
@FragmentedPacket
Copy link
Contributor

Using PR #667 due to line endings in this PR not showing the actual changes, but replacing the whole file.

@dhanasekaar
Copy link
Author

Thanks for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants