New Template: Cisco IOS show ip bgp neighbor #583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support to parse output from `show ip bgp neighbor`. A lot more output could be retrieved from this command, I only took what I needed for now.
FragmentedPacket
suggested changes
Jan 29, 2020
tests/cisco_ios/show_ip_bgp_neighbor/cisco_ios_show_ip_bgp_neighbor.raw
Outdated
Show resolved
Hide resolved
FragmentedPacket
added
changes_requested
kwrobert
force-pushed
the
cisco_ios_show_ip_bgp_neighbor
branch
from
f67d05c
to
872213c
Compare
FragmentedPacket
suggested changes
Jan 29, 2020
| ============================================================================= | ||
| BGP neighbor is 175.135.172.146, remote AS 65180, internal link | ||
| Description: nsxe-core-rtr1 | ||
| Member of peer-group HMCO-core for session parameters |
There was a problem hiding this comment.
I would update any values that are using \w+ and change them to \S+. This will capture the peer_group: 'HMCO-core' within the parsed file.
…ner in .raw test file
|
@kwrobert Just an FYI you can pip install tox and then just run tox command for it to run the tests locally before pushing up and waiting for Travis CI |
|
Closed by #590 Thanks for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
Template: cisco_ios_show_ip_bgp_neighbor.textfsm
OS: Cisco IOS
Command: `show ip bgp neighbor
SUMMARY
Added support to parse output from
show ip bgp neighborbecause it contains some information not available in the output ofshow ip bgp summary.A lot more output could be retrieved from this command, I only took what I needed for now.