Cleanup some testing #551
Merged
Cleanup some testing #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename template to show_ip_ospf_neighbor.template * Rename test directory * Update index entry with new name and update command syntax regex
Fix tests feedback
thomasblass
pushed a commit
to thomasblass/ntc-templates
that referenced
this pull request
Oct 25, 2020
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
Tests
SUMMARY
Fixes #550
This fixes the 4 tests that were skipped. Two of them were already fixed and didn't need any remediation (
cisco_ios_show_vlan,cisco_nxos_show_interface_brief)cisco_nxos_show_ip_ospf_neighbor_vrf
Was fixed by removing
_vrfand changing the index and test directories for the changecisco_xr_show_controllers
This was changed to match the other
show controller Xtemplates since there are multiple options and each return different output so best to have them as separate templates.Tests
Cleaned up and to parametrize the
test_testcasestests to be able to report for each test case when running pytest