Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show 802 11a|b cleanair config #504

Merged
merged 2 commits into from
Oct 27, 2019
Merged

Show 802 11a|b cleanair config #504

merged 2 commits into from
Oct 27, 2019

Conversation

timjsmith24
Copy link
Contributor

ISSUE TYPE
  • New Template Pull Request
COMPONENT

cisco_wlc_ssh_show_802_11b_cleanair_config.template, .*, cisco_wlc_ssh, show 802.11b cleanair config

SUMMARY

@jmcgill298
Copy link
Contributor

This looks to be a superset of 802.11a output, does it make sense to have one template and fix the index to allow the command to support 80211.a|b?

@timjsmith24 timjsmith24 changed the title Show 802 11b cleanair config Show 802 11a|b cleanair config Oct 23, 2019
@timjsmith24
Copy link
Contributor Author

I'm good with this. I have updated the template name and index to apply to both radios

@timjsmith24
Copy link
Contributor Author

I add the same fixes for the literal . in the index file to this template as well.

@jmcgill298
Copy link
Contributor

@timjsmith24 can you rebase this since I merged the other PR which added the fix in the test file? Otherwise this should be good.

@jmcgill298
Copy link
Contributor

Actually, I just realized that my updates were missing the EoL ($$) for matching blank lines, I updated the show 802.11ab template, but this one will also need to add that. I think this will also require adding more match lines to at least match the insignificant lines.

@timjsmith24 timjsmith24 reopened this Oct 26, 2019
@timjsmith24
Copy link
Contributor Author

Not sure why this closed. But I reopened it. I am having a problem after rebasing. The other command 'show 802.11ab' keeps failing. I am not sure if it has to do with the '.' in the template name? If I remove the files for "cisco_wlc_ssh_show_802.11ab.template" or if I remove the files for "cisco_wlc_ssh_show_802.11ab_cleanair_config.template" it will pass but not when both templates and files are in.

@jmcgill298 jmcgill298 changed the base branch from master to show_802_11b_cleanair_config October 27, 2019 22:29
@jmcgill298 jmcgill298 merged commit 2f4d31d into networktocode:show_802_11b_cleanair_config Oct 27, 2019
@jmcgill298
Copy link
Contributor

Thanks @timjsmith24 The tests weren't really written to with templates being able to support multiple commands, so I renamed the directories and templates to just use show 802.11a but CliTable should still work with 802.11a and 802.11b.

@timjsmith24 timjsmith24 deleted the show_802_11b_cleanair_config branch October 29, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants