Fixes #424: Cisco ASA - show failover error. #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FragmentedPacket
suggested changes
Sep 27, 2019
There was a problem hiding this comment.
@deesel Do you mind adding a new raw and parsed with the new output?
FragmentedPacket
added
bug
changes_requested
|
Can you add that it fixes #424 within the original comment on this PR? It should close that issue once this is merged. |
FragmentedPacket
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
cisco_asa_show_failover
SUMMARY
The output of "show failover" command includes additional line in newer ASA versions:
ASA FirePOWER, 5.4.1-211, Up, (Monitored)Which seems to be causing the problem.