Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cisco_xr_show_version.template #442

Merged
merged 3 commits into from
Sep 20, 2019

Conversation

mspiez
Copy link
Contributor

@mspiez mspiez commented Jul 24, 2019

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT

cisco_xr_show_version.template

SUMMARY

Typo:

- ^\s+Build\sHost\s+:\s+${BUILD_HOST}
+ ^\s+Built\sHost\s+:\s+${BUILD_HOST}

@IceN9ne
Copy link

IceN9ne commented Aug 6, 2019

This should probably be updated to Buil[dt]. I compared many different cXR and eXR versions across ASR and NCS devices and only found that line to be on eXR devices and specifically Built only on 6.5.3 ASR and 7.0.1 NCS-6000. 6.5.2 on ASR has the Build string. Looks like this is a recent change in the "Built" process.

I found it interesting that 6.5.3 on NCS-5500 has the original Build and doesn't match the change on ASR. Also interesting is eXR 7.0.1 on NCS-6000 has the updated Built string though.

@mspiez
Copy link
Contributor Author

mspiez commented Sep 10, 2019

Both options should be supported.
Template updated to support two version of output: Build: and Built:

+ ^\s+Buil[dt]\sHost\s+:\s+${BUILD_HOST}

Also added test files to support second case.

@FragmentedPacket FragmentedPacket merged commit 45c7879 into networktocode:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants