Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cisco_wlc_ssh_show_exclusionlist #425

Merged
merged 6 commits into from
Sep 27, 2019
Merged

add cisco_wlc_ssh_show_exclusionlist #425

merged 6 commits into from
Sep 27, 2019

Conversation

ancker010
Copy link
Contributor

ISSUE TYPE
  • New Template Pull Request
COMPONENT

Cisco WLC SSH, 'show exclusionlist'.

SUMMARY

Template will read MAC addresses and comments from the Cisco WLC exclusionlist.

@jvanderaa
Copy link
Contributor

I'm seeing that the exclusionlist has a bunch of manually generated exclusions (makes sense). Would it also catch the dynamically excluded clients?

Asking as someone that is particularly interested in doing a few more WLC SSH templates in the future.

@ancker010
Copy link
Contributor Author

I'm seeing that the exclusionlist has a bunch of manually generated exclusions (makes sense). Would it also catch the dynamically excluded clients?

Asking as someone that is particularly interested in doing a few more WLC SSH templates in the future.

I'm not sure. I don't have any in my production system so I wasn't able to test for that.
I assume it follows the same format, but instead of Description there is a "Reason" or something that caused the dynamic exclusion.

Copy link
Contributor

@FragmentedPacket FragmentedPacket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a header catch so we can make sure the data we're trying to catch is correct?

This would like the following:

Start
  ^MAC\s+Address\s+Description -> ManuallyDisabled

ManuallyDisabled
  ^${mac}\s+${comment} -> Record
  ^No\s*dynamically
  ^\s*$$
  ^. -> Error

Also, can you make the values uppercase, e.g. MAC & COMMENT

@FragmentedPacket FragmentedPacket added the changes_requested Waiting on user to address feedback label Sep 27, 2019
@ancker010
Copy link
Contributor Author

Done.

@FragmentedPacket
Copy link
Contributor

Sorry that wasn't the complete change was just a suggestion:

Value MAC (([\da-fA-F]{2}[-:]){5}[\da-fA-F]{2})
Value COMMENT (.*)

Start
  ^Manually\s*Disabled\s*Clients -> ManuallyDisabled
  ^No\s*dynamically
  ^\s*$$
  ^. -> Error

ManuallyDisabled
  ^---
  ^MAC\s+Address\s+Description
  ^${MAC}\s+${COMMENT} -> Record
  ^\s*$$ -> Start

@ancker010
Copy link
Contributor Author

Sorry. Regex isn't my strong suit.
Updated and tests pass.

@FragmentedPacket FragmentedPacket merged commit 0a91c4e into networktocode:master Sep 27, 2019
@ancker010 ancker010 deleted the cisco_wlc_ssh_show_exclusionlist branch September 30, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants