Feature/cisco ios show hosts #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FragmentedPacket
suggested changes
Jul 27, 2019
| @@ -0,0 +1,12 @@ | |||
| Value DEFAULT_DOMAIN (\S+) | |||
| Value NAME_SERVERS ([\S ]+) | |||
There was a problem hiding this comment.
Can you change the NAME_SERVERS regex to .+?
Also, can you please change any static spacing within the Start state to either \s* or \s+?
After those are addressed, we can merge this.
There was a problem hiding this comment.
Thank you for pointing out the NAME_SERVERS.
I also updated the regex in the start state...
FragmentedPacket
approved these changes
Aug 2, 2019
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
New template: cisco_ios_show_hosts_summary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
Template: cisco_ios_show_hosts_summary
OS: Cisco IOS
Command: show hosts summary
SUMMARY
Add a new template for the cisco ios show hosts summary which parses the default_domain, name_servers, local cache entries and dynamic cache entries.
the name servers are a comma separated string instead a list, because i couldn't get it to work.