Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XR SHOW CONTROLLERS FABRIC FIA DROPS EGRESS: Add new template #355

Merged
merged 5 commits into from
Feb 23, 2019

Conversation

jmcgill298
Copy link
Contributor

ISSUE TYPE
  • New Template Pull Request
COMPONENT

cisco_xr_show_controllers_fabric_fia_drops_egress

SUMMARY

Add new template


vaneuk and others added 3 commits January 26, 2019 16:52
GENERAL UPDATES:
- Change whitespace matching to use `\s+`
- Change `Record` to happen on FIA location line
TEMPLATE UPDATES:
- Change variable data to be a list
  * Allows for platforms with additional capacity to still work
  * Changed capture groups:
    `FROM_XBAR_UC_CRC_$variable` -> `FROM_XBAR_UNICAST_LOCATION` & `FROM_XBAR_UNICAST_CRC_COUNT`
    `FROM_XBAR_UC_DRP_$variable` -> `FROM_XBAR_UNICAST_LOCATION` & `FROM_XBAR_UNICAST_DROP_COUNT`
    `FROM_XBAR_MC_CRC_$variable` -> `FROM_XBAR_MULTICAST_LOCATION` & `FROM_XBAR_MULTICAST_CRC_COUNT`
    `FROM_XBAR_MC_DRP_$variable` -> `FROM_XBAR_MULTICAST_LOCATION` & `FROM_XBAR_MULTICAST_DROP_COUNT`
    `MC_VL$variable_SRC$variable_BUFFER_FULL_DRP` -> `MULTICAST_VL_LOCATION`, `MULTICAST_SRC_LOCATION`, & `MULTICAST_BUFFER_FULL_DROP_COUNT`

TEST FILES:
- Update parsed file to use lists with new capture group names
@jmcgill298
Copy link
Contributor Author

@vaneuk My last commit to this branch makes some big changes. I think it makes sense to capture the data as lists in order to account for different architectures. Please let me know what you think of my data representation.

@jmcgill298
Copy link
Contributor Author

based on conversation on #358 I will revert 98713c2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants