XR SHOW CONTROLLERS: Bug Fix #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current template did not work for TenGig Interface data
BREAKING CHANGES:
- Change threshold settings to `Filldown` instead of recording
* `TX_ALARM_HIGH`
* `TX_WARN_HIGH`
* `TX_WARN_LOW`
* `TX_ALARM_LOW`
* `RX_ALARM_HIGH`
* `RX_WARN_HIGH`
* `RX_WARN_LOW`
* `RX_ALARM_LOW`
GENERAL UPDATES:
- CHANGE `TX_VALUE` and `RX_VALUE` to capture everything between parenthesis
* Values at the extremes have extra characters not previously accounted for
- Create regex matches for TenGig raw data
- Remove `EOF` and clear all filldown data to prevent extra `Record`
TEST FILES:
- Added raw and parsed files for TenGig interfaces
- Updated existing parsed file to filldown threshold values, which decreases `Record` counts
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
XR SHOW CONTROLLERS: Bug Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
cisco_xr_show_controllers
SUMMARY
Current template did not work for TenGig Interface data
BREAKING CHANGES:
Filldowninstead of recordingTX_ALARM_HIGHTX_WARN_HIGHTX_WARN_LOWTX_ALARM_LOWRX_ALARM_HIGHRX_WARN_HIGHRX_WARN_LOWRX_ALARM_LOWGENERAL UPDATES:
TX_VALUEandRX_VALUEto capture everything between parenthesisEOFand clear all filldown data to prevent extraRecordTEST FILES:
Recordcounts