Patch 2 #342
Merged
Patch 2 #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we had an issue with the below output as it would repeat the headers as part of the returned values. The solution is to fix the regular expressions, as they would match too broad. For instance the expression `(\w+.\w+.\w+)` would match things like `A B C` or `Nightmare|On|ElmStreet`. Dots should be matched using `\.` and for a mac-address the regexp could be much more strict. Same for vlan numbers we know it's between 1 and 4 digits.
jvanderaa
pushed a commit
that referenced
this pull request
Nov 10, 2021
* Fix standard regular expressions to skip headers * Add test files for template update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
COMPONENT
cisco_ios_show_mac-address-table
SUMMARY
Add new format that cam table is presented from cli