Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brocade fastiron show arp #289

Merged

Conversation

jkraszewski
Copy link
Contributor

ISSUE TYPE
  • New Template Pull Request
COMPONENT

brocade_fastiron_show_arp.template, fastiron, show arp

SUMMARY

New brocade template

Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think all of these should be required, maybe in the future another model/version might look different.

Also add a match for an empty line just in case that shows up in a different model/version

@@ -0,0 +1,11 @@
Value Required PROTOCOL (\S+)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Value Required PROTOCOL (\S+)
Value PROTOCOL (\S+)

@@ -0,0 +1,11 @@
Value Required PROTOCOL (\S+)
Value Required IP_ADDRESS ([A-Fa-f0-9:\.]+)
Value Required AGE (\S+)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Value Required AGE (\S+)
Value AGE (\S+)

Value Required IP_ADDRESS ([A-Fa-f0-9:\.]+)
Value Required AGE (\S+)
Value Required MAC_ADDRESS ([A-Fa-f0-9\.]{14})
Value Required TYPE (\S+)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Value Required TYPE (\S+)
Value TYPE (\S+)

templates/brocade_fastiron_show_arp.template Show resolved Hide resolved
@jmcgill298 jmcgill298 merged commit 794f5cf into networktocode:master Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants