Packaging #288
Packaging #288
Conversation
There was a problem hiding this comment.
71038c7 - I do not think it is a good idea to do import from the package as that might create a circular dependency and cause the install to fail.
Otherwise I think it looks good. I am still talking with a few other people to confirm this works for them.
I am also going to change the requirements to use textfsm instead of gtextfsm so you might need to rebase.
|
Hi @jmcgill298, I use an import like in 71038c7 to handle gathering the version number in other projects I work on. Unfortunately they're not public for me to be able to link to them. It works, as long as the current working directory when However, I can understand not wanting to change something that works. I'll go ahead and revert that change so as not to distract from the rest of the PR. I'm totally in favor of the switch to |
|
I see It looks like they still only have version 0.4.1 on PyPI, and I think this project will need at least version 1 for import compatibility. |
|
This is a good page highlighting the options for versioning: Thanks for pointing out the import issues with |
|
@jmcgill298 is there anything outstanding on this PR? |
* remove redundant 'templates/*' - these files are covered by package_data in setup.py * declare package_data files explicitly * delete red herring comment * stop messing with symlinks - they are not needed * remove unused imports * ln -s ntc_templates/templates ../templates * simplify version number gathering * simplify file finding * whitespace * document that we are zip-unsafe because we operate on real file paths * delete redundant comment * revert version-identification change. See discussion on #288 * remove redundant 'templates/*' - these files are covered by package_data in setup.py * declare package_data files explicitly * delete red herring comment * stop messing with symlinks - they are not needed * remove unused imports * ln -s ntc_templates/templates ../templates * simplify version number gathering * simplify file finding * whitespace * document that we are zip-unsafe because we operate on real file paths * delete redundant comment * revert version-identification change. See discussion on #288
ISSUE TYPE
COMPONENT
Python packaging
SUMMARY
Made Python packaging simpler and more deterministic.
This PR:
ntc_templates/templateswill point totemplates. This puts the templates inside the path of the Python project, which makes packaging tools happy. It also allows thetemplatesdirectory to stay where it is, so existing PRs and tooling can still reference templates in the same location.