Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cisco_nxos_show_version to support 5ks #154

Merged
merged 2 commits into from
Jan 21, 2019

Conversation

amb1s1
Copy link
Contributor

@amb1s1 amb1s1 commented Sep 28, 2017

The current version will not match 5ks platforms. I made a change to support the old 5ks to match the platform.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT

cisco_nxos_show_version

SUMMARY
Just the platform messages:
ok: [n9k02.doubleverify.prod] => {
    "msg": "C9504"
}
ok: [10.30.153.126] => {
    "msg": "C92160YC"
}
ok: [n9k01.doubleverify.prod] => {
    "msg": "C9504"
}
ok: [10.30.153.9] => {
    "msg": "C9372PX"
}
ok: [10.30.153.127] => {
    "msg": "C92160YC"
}
ok: [10.30.153.11] => {
    "msg": "C9372PX"
}
ok: [10.30.153.15] => {
    "msg": "Chassis"
}
ok: [10.30.153.16] => {
    "msg": "Chassis"
}
ok: [10.30.151.211] => {
    "msg": "Chassis"
}
ok: [10.30.151.212] => {
    "msg": "Chassis"
}

After:
ok: [n9k01.doubleverify.prod] => {
    "msg": "C9504"
}
ok: [10.30.153.127] => {
    "msg": "C92160YC"
}
ok: [n9k02.doubleverify.prod] => {
    "msg": "C9504"
}
ok: [10.30.153.9] => {
    "msg": "C9372PX"
}
ok: [10.30.153.126] => {
    "msg": "C92160YC"
}
ok: [10.30.153.11] => {
    "msg": "C9372PX"
}
ok: [10.30.153.15] => {
    "msg": "Nexus5548"
}
ok: [10.30.153.16] => {
    "msg": "Nexus5548"
}
ok: [10.30.151.211] => {
    "msg": "Nexus5020"
}
ok: [10.30.151.212] => {
    "msg": "Nexus5020"
}

The current version will not match 5ks platforms. I made a change to support the old 5ks to match the platform.
@itdependsnetworks
Copy link
Contributor

@amb1s1 can you add the additional test? If you need any help, you know where to reach us.

@jmcgill298 jmcgill298 merged commit f0dc741 into networktocode:master Jan 21, 2019
jvanderaa pushed a commit that referenced this pull request Nov 10, 2021
The `PLATFORM` Capture Group has a different syntax in Nexus 5K platform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants