Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added VLAN value and search pattern #1002

Merged
merged 2 commits into from
Oct 15, 2021
Merged

added VLAN value and search pattern #1002

merged 2 commits into from
Oct 15, 2021

Conversation

dbell-infra
Copy link
Contributor

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT

template: cisco_asa_show_interface.textfsm
os: cisco.asa
command: show interface

SUMMARY

Currently the Cisco ASA template does not include a VLAN value and regex. This causes error when attempting to parse devices with sub-interface configurations. Adding the VLAN value and search string allows for successful parsing.

BEFORE CHANGE

fatal: [core_fw_01]: FAILED! => {"changed": false, "msg": "State Error raised. Rule Line: 67. Input Line: \tVLAN identifier 60"}

AFTER CHANGE

"msg": [
        {
            "ADDRESS": "0c29.a40a.f201",
            "BANDWIDTH": "1000 Mbps",
            "DELAY": "10 usec",
            "DESCRIPTION": "",
            "DUPLEX": "Full-duplex",
            "FIVEMIN_DROP_RATE": "",
            "FIVEMIN_IN_PPS": "",
            "FIVEMIN_IN_RATE": "",
            "FIVEMIN_OUT_PPS": "",
            "FIVEMIN_OUT_RATE": "",
            "HARDWARE_TYPE": "i82540EM rev03",
            "INTERFACE": "GigabitEthernet0/0",
            "INTERFACE_ZONE": "",
            "IP_ADDRESS": "",
            "LINK_STATUS": "up",
            "MTU": "",
            "NET_MASK": "",
            "ONEMIN_DROP_RATE": "",
            "ONEMIN_IN_PPS": "",
            "ONEMIN_IN_RATE": "",
            "ONEMIN_OUT_PPS": "",
            "ONEMIN_OUT_RATE": "",
            "PROTOCOL_STATUS": "up",
            "SPEED": "1000 Mbps",
            "VLAN": ""
        },
        {
            "ADDRESS": "0c29.a40a.f201",
            "BANDWIDTH": "1000 Mbps",
            "DELAY": "10 usec",
            "DESCRIPTION": "",
            "DUPLEX": "",
            "FIVEMIN_DROP_RATE": "",
            "FIVEMIN_IN_PPS": "",
            "FIVEMIN_IN_RATE": "",
            "FIVEMIN_OUT_PPS": "",
            "FIVEMIN_OUT_RATE": "",
            "HARDWARE_TYPE": "i82540EM rev03",
            "INTERFACE": "GigabitEthernet0/0.60",
            "INTERFACE_ZONE": "FINANCE",
            "IP_ADDRESS": "10.29.60.1",
            "LINK_STATUS": "up",
            "MTU": "1500",
            "NET_MASK": "255.255.255.0",
            "ONEMIN_DROP_RATE": "",
            "ONEMIN_IN_PPS": "",
            "ONEMIN_IN_RATE": "",
            "ONEMIN_OUT_PPS": "",
            "ONEMIN_OUT_RATE": "",
            "PROTOCOL_STATUS": "up",
            "SPEED": "",
            "VLAN": "60"
        },
        {
            "ADDRESS": "0c29.a40a.f201",
            "BANDWIDTH": "1000 Mbps",
            "DELAY": "10 usec",
            "DESCRIPTION": "",
            "DUPLEX": "",
            "FIVEMIN_DROP_RATE": "",
            "FIVEMIN_IN_PPS": "",
            "FIVEMIN_IN_RATE": "",
            "FIVEMIN_OUT_PPS": "",
            "FIVEMIN_OUT_RATE": "",
            "HARDWARE_TYPE": "i82540EM rev03",
            "INTERFACE": "GigabitEthernet0/0.70",
            "INTERFACE_ZONE": "SALES",
            "IP_ADDRESS": "10.29.70.1",
            "LINK_STATUS": "up",
            "MTU": "1500",
            "NET_MASK": "255.255.255.0",
            "ONEMIN_DROP_RATE": "",
            "ONEMIN_IN_PPS": "",
            "ONEMIN_IN_RATE": "",
            "ONEMIN_OUT_PPS": "",
            "ONEMIN_OUT_RATE": "",
            "PROTOCOL_STATUS": "up",
            "SPEED": "",
            "VLAN": "70"
        },
        {
            "ADDRESS": "0c29.a40a.f201",
            "BANDWIDTH": "1000 Mbps",
            "DELAY": "10 usec",
            "DESCRIPTION": "",
            "DUPLEX": "",
            "FIVEMIN_DROP_RATE": "",
            "FIVEMIN_IN_PPS": "",
            "FIVEMIN_IN_RATE": "",
            "FIVEMIN_OUT_PPS": "",
            "FIVEMIN_OUT_RATE": "",
            "HARDWARE_TYPE": "i82540EM rev03",
            "INTERFACE": "GigabitEthernet0/0.80",
            "INTERFACE_ZONE": "ENGINEERING",
            "IP_ADDRESS": "10.29.80.1",
            "LINK_STATUS": "up",
            "MTU": "1500",
            "NET_MASK": "255.255.255.0",
            "ONEMIN_DROP_RATE": "",
            "ONEMIN_IN_PPS": "",
            "ONEMIN_IN_RATE": "",
            "ONEMIN_OUT_PPS": "",
            "ONEMIN_OUT_RATE": "",
            "PROTOCOL_STATUS": "up",
            "SPEED": "",
            "VLAN": "80"
        },
        {
            "ADDRESS": "0c29.a40a.f201",
            "BANDWIDTH": "1000 Mbps",
            "DELAY": "10 usec",
            "DESCRIPTION": "",
            "DUPLEX": "",
            "FIVEMIN_DROP_RATE": "",
            "FIVEMIN_IN_PPS": "",
            "FIVEMIN_IN_RATE": "",
            "FIVEMIN_OUT_PPS": "",
            "FIVEMIN_OUT_RATE": "",
            "HARDWARE_TYPE": "i82540EM rev03",
            "INTERFACE": "GigabitEthernet0/0.90",
            "INTERFACE_ZONE": "SERVERS",
            "IP_ADDRESS": "10.29.90.1",
            "LINK_STATUS": "up",
            "MTU": "1500",
            "NET_MASK": "255.255.255.0",
            "ONEMIN_DROP_RATE": "",
            "ONEMIN_IN_PPS": "",
            "ONEMIN_IN_RATE": "",
            "ONEMIN_OUT_PPS": "",
            "ONEMIN_OUT_RATE": "",
            "PROTOCOL_STATUS": "up",
            "SPEED": "",
            "VLAN": "90"
        },
        {
            "ADDRESS": "0c29.a40a.f202",
            "BANDWIDTH": "1000 Mbps",
            "DELAY": "10 usec",
            "DESCRIPTION": "",
            "DUPLEX": "Full-duplex",
            "FIVEMIN_DROP_RATE": "0",
            "FIVEMIN_IN_PPS": "0",
            "FIVEMIN_IN_RATE": "9",
            "FIVEMIN_OUT_PPS": "0",
            "FIVEMIN_OUT_RATE": "9",
            "HARDWARE_TYPE": "i82540EM rev03",
            "INTERFACE": "GigabitEthernet0/1",
            "INTERFACE_ZONE": "OUTSIDE",
            "IP_ADDRESS": "10.29.100.1",
            "LINK_STATUS": "up",
            "MTU": "1500",
            "NET_MASK": "255.255.255.0",
            "ONEMIN_DROP_RATE": "0",
            "ONEMIN_IN_PPS": "0",
            "ONEMIN_IN_RATE": "9",
            "ONEMIN_OUT_PPS": "0",
            "ONEMIN_OUT_RATE": "8",
            "PROTOCOL_STATUS": "up",
            "SPEED": "1000 Mbps",
            "VLAN": ""
        },

Tested via parse_cli_textfsm Ansible plugin and ASAv 9.8(1)

@jvanderaa
Copy link
Contributor

Please add in tests with the new keys and values.

@dbell-infra
Copy link
Contributor Author

@jvanderaa
Thank you for the response on the PR, new test case/raw data has been added

jvanderaa
jvanderaa approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@jvanderaa jvanderaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvanderaa jvanderaa merged commit 9362ca2 into networktocode:master Oct 15, 2021
jvanderaa pushed a commit that referenced this pull request Nov 10, 2021
@dbell-infra
added VLAN value and search pattern (#1002)
c66798a 
* Add VLAN value for Cisco ASA `show interface`
guillaume-mbali pushed a commit to unyc-io/ntc-templates that referenced this pull request Apr 12, 2023
@dbell-infra
added VLAN value and search pattern (networktocode#1002)
1857a17 
* Add VLAN value for Cisco ASA `show interface`
cppmonkey pushed a commit to cppmonkey/ntc-templates that referenced this pull request Oct 25, 2023
@dbell-infra @cppmonkey
added VLAN value and search pattern (networktocode#1002)
03902c1 
* Add VLAN value for Cisco ASA `show interface`
@mjbear mjbear mentioned this pull request Jul 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvanderaa jvanderaa jvanderaa approved these changes

@FragmentedPacket FragmentedPacket Awaiting requested review from FragmentedPacket

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

@jmcgill298 jmcgill298 Awaiting requested review from jmcgill298 jmcgill298 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbell-infra @jvanderaa @daltonb-escalations