Update container update/api-gomod #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i@master Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
that referenced
this pull request
Apr 3, 2021
…i@master networkservicemesh/api# networkservicemesh/api PR link: https://github.com/networkservicemesh/api/pull/ networkservicemesh/api commit message: commit 2aa71ad8270a327a91e69e78aa11af7a4d1c42b7 Author: Ed Warnicke <hagbard@gmail.com> Date: Fri Apr 2 19:08:18 2021 -0500 Fix proto generation (#86) We previously had some breakage in proto generation. This is fixed by upgrading to a recent protoc and proto-gen-go. Note: this does shift which empty and timestamp packages we import, but through the magic of: https://github.com/golang/protobuf/blob/master/ptypes/empty/empty.pb.go#L15 and https://github.com/golang/protobuf/blob/master/ptypes/timestamp/timestamp.pb.go#L15 we have backwards compatibility for our existing code. Signed-off-by: Ed Warnicke <hagbard@gmail.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to update the container collection update/api-gomod