fix: expire chain element could work incorrectly with registry-k8s #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Jan 13, 2021
…k@master networkservicemesh/sdk#649 networkservicemesh/sdk PR link: networkservicemesh/sdk#649 networkservicemesh/sdk commit message: commit a7a5294511d8bb803fe6fa959345535e76b2c002 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 14 01:32:30 2021 +0700 fix: expire chain element could work incorrectly with registry-k8s (#649) * fix couple issues of expire chain element Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Jan 13, 2021
…k@master networkservicemesh/sdk#649 networkservicemesh/sdk PR link: networkservicemesh/sdk#649 networkservicemesh/sdk commit message: commit a7a5294511d8bb803fe6fa959345535e76b2c002 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 14 01:32:30 2021 +0700 fix: expire chain element could work incorrectly with registry-k8s (#649) * fix couple issues of expire chain element Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Jan 13, 2021
…k@master networkservicemesh/sdk#649 networkservicemesh/sdk PR link: networkservicemesh/sdk#649 networkservicemesh/sdk commit message: commit a7a5294511d8bb803fe6fa959345535e76b2c002 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 14 01:32:30 2021 +0700 fix: expire chain element could work incorrectly with registry-k8s (#649) * fix couple issues of expire chain element Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Jan 13, 2021
…k@master networkservicemesh/sdk#649 networkservicemesh/sdk PR link: networkservicemesh/sdk#649 networkservicemesh/sdk commit message: commit a7a5294511d8bb803fe6fa959345535e76b2c002 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 14 01:32:30 2021 +0700 fix: expire chain element could work incorrectly with registry-k8s (#649) * fix couple issues of expire chain element Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vppagent
that referenced
this pull request
Jan 13, 2021
…k@master networkservicemesh/sdk#649 networkservicemesh/sdk PR link: networkservicemesh/sdk#649 networkservicemesh/sdk commit message: commit a7a5294511d8bb803fe6fa959345535e76b2c002 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 14 01:32:30 2021 +0700 fix: expire chain element could work incorrectly with registry-k8s (#649) * fix couple issues of expire chain element Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Jan 13, 2021
…k@master networkservicemesh/sdk#649 networkservicemesh/sdk PR link: networkservicemesh/sdk#649 networkservicemesh/sdk commit message: commit a7a5294511d8bb803fe6fa959345535e76b2c002 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 14 01:32:30 2021 +0700 fix: expire chain element could work incorrectly with registry-k8s (#649) * fix couple issues of expire chain element Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Jan 13, 2021
…k@master networkservicemesh/sdk#649 networkservicemesh/sdk PR link: networkservicemesh/sdk#649 networkservicemesh/sdk commit message: commit a7a5294511d8bb803fe6fa959345535e76b2c002 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 14 01:32:30 2021 +0700 fix: expire chain element could work incorrectly with registry-k8s (#649) * fix couple issues of expire chain element Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Jan 13, 2021
…k@master networkservicemesh/sdk#649 networkservicemesh/sdk PR link: networkservicemesh/sdk#649 networkservicemesh/sdk commit message: commit a7a5294511d8bb803fe6fa959345535e76b2c002 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 14 01:32:30 2021 +0700 fix: expire chain element could work incorrectly with registry-k8s (#649) * fix couple issues of expire chain element Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Jan 13, 2021
…k@master networkservicemesh/sdk#649 networkservicemesh/sdk PR link: networkservicemesh/sdk#649 networkservicemesh/sdk commit message: commit a7a5294511d8bb803fe6fa959345535e76b2c002 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 14 01:32:30 2021 +0700 fix: expire chain element could work incorrectly with registry-k8s (#649) * fix couple issues of expire chain element Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jan 13, 2021
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Jan 13, 2021
…k@master networkservicemesh/sdk#649 networkservicemesh/sdk PR link: networkservicemesh/sdk#649 networkservicemesh/sdk commit message: commit a7a5294511d8bb803fe6fa959345535e76b2c002 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 14 01:32:30 2021 +0700 fix: expire chain element could work incorrectly with registry-k8s (#649) * fix couple issues of expire chain element Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
denis-tingaikin
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Jan 14, 2021
…k@master networkservicemesh/sdk#649 networkservicemesh/sdk PR link: networkservicemesh/sdk#649 networkservicemesh/sdk commit message: commit a7a5294511d8bb803fe6fa959345535e76b2c002 Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Thu Jan 14 01:32:30 2021 +0700 fix: expire chain element could work incorrectly with registry-k8s (#649) * fix couple issues of expire chain element Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issues Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During testing cmd-registry-k8s were found a few issues:
expirens registry chain element uses deadline contextexpirense registry chain element should use actual NSE on unregistering