Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make updatepath restore path index on return #602

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Make updatepath restore path index on return #602

merged 2 commits into from
Nov 24, 2020

Conversation

Bolodya1997
Copy link

Issue

Update path doesn't update path index back on return. If chain elements accesses Path.Index after next.().Request there is no guarantee that it is pointing to the current path segment.

Solution

Set conn.Path.Index = request.Connection.Path.Index on return.

Vladimir Popov added 2 commits November 24, 2020 13:52
Make updatepath restore path index on return
1d4d148 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Remove update path segment from updatetoken
c4d6749 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@haiodo haiodo merged commit 9d14c5e into networkservicemesh:master Nov 24, 2020
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Nov 24, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c70902f 
…k@master networkservicemesh/sdk#602

networkservicemesh/sdk PR link: networkservicemesh/sdk#602

networkservicemesh/sdk commit message:
commit 9d14c5e5b57ec2ccd62f7f219a819782f17e4030
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Tue Nov 24 15:33:29 2020 +0700

    Make updatepath restore path index on return (#602)

    * Make updatepath restore path index on return

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Remove update path segment from updatetoken

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Nov 24, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
19f691f 
…k@master networkservicemesh/sdk#602

networkservicemesh/sdk PR link: networkservicemesh/sdk#602

networkservicemesh/sdk commit message:
commit 9d14c5e5b57ec2ccd62f7f219a819782f17e4030
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Tue Nov 24 15:33:29 2020 +0700

    Make updatepath restore path index on return (#602)

    * Make updatepath restore path index on return

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Remove update path segment from updatetoken

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Nov 24, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f220a56 
…k@master networkservicemesh/sdk#602

networkservicemesh/sdk PR link: networkservicemesh/sdk#602

networkservicemesh/sdk commit message:
commit 9d14c5e5b57ec2ccd62f7f219a819782f17e4030
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Tue Nov 24 15:33:29 2020 +0700

    Make updatepath restore path index on return (#602)

    * Make updatepath restore path index on return

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Remove update path segment from updatetoken

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-vpp that referenced this pull request Nov 24, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
aadce18 
…k@master networkservicemesh/sdk#602

networkservicemesh/sdk PR link: networkservicemesh/sdk#602

networkservicemesh/sdk commit message:
commit 9d14c5e5b57ec2ccd62f7f219a819782f17e4030
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Tue Nov 24 15:33:29 2020 +0700

    Make updatepath restore path index on return (#602)

    * Make updatepath restore path index on return

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Remove update path segment from updatetoken

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Nov 24, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4ccfa6b 
…k@master networkservicemesh/sdk#602

networkservicemesh/sdk PR link: networkservicemesh/sdk#602

networkservicemesh/sdk commit message:
commit 9d14c5e5b57ec2ccd62f7f219a819782f17e4030
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Tue Nov 24 15:33:29 2020 +0700

    Make updatepath restore path index on return (#602)

    * Make updatepath restore path index on return

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Remove update path segment from updatetoken

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Nov 24, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1b13904 
…k@master networkservicemesh/sdk#602

networkservicemesh/sdk PR link: networkservicemesh/sdk#602

networkservicemesh/sdk commit message:
commit 9d14c5e5b57ec2ccd62f7f219a819782f17e4030
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Tue Nov 24 15:33:29 2020 +0700

    Make updatepath restore path index on return (#602)

    * Make updatepath restore path index on return

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Remove update path segment from updatetoken

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Nov 24, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
450061b 
…k@master networkservicemesh/sdk#602

networkservicemesh/sdk PR link: networkservicemesh/sdk#602

networkservicemesh/sdk commit message:
commit 9d14c5e5b57ec2ccd62f7f219a819782f17e4030
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Tue Nov 24 15:33:29 2020 +0700

    Make updatepath restore path index on return (#602)

    * Make updatepath restore path index on return

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Remove update path segment from updatetoken

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-vppagent that referenced this pull request Nov 24, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
7be24f0 
…k@master networkservicemesh/sdk#602

networkservicemesh/sdk PR link: networkservicemesh/sdk#602

networkservicemesh/sdk commit message:
commit 9d14c5e5b57ec2ccd62f7f219a819782f17e4030
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Tue Nov 24 15:33:29 2020 +0700

    Make updatepath restore path index on return (#602)

    * Make updatepath restore path index on return

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Remove update path segment from updatetoken

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 24, 2020
Merged
Merged
Merged
Merged
Merged
Merged
illbegood pushed a commit to illbegood/sdk that referenced this pull request Dec 20, 2020
Make updatepath restore path index on return (networkservicemesh#602)
2289451 
* Make updatepath restore path index on return

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Remove update path segment from updatetoken

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
illbegood pushed a commit to illbegood/sdk that referenced this pull request Dec 20, 2020
Make updatepath restore path index on return (networkservicemesh#602)
de6c66c 
* Make updatepath restore path index on return

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Remove update path segment from updatetoken

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
illbegood pushed a commit to illbegood/sdk that referenced this pull request Dec 23, 2020
Make updatepath restore path index on return (networkservicemesh#602)
a50484a 
* Make updatepath restore path index on return

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Remove update path segment from updatetoken

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bolodya1997 @haiodo