Get rid of nil filters for nsmgr #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
remove_nil_filter
branch
from
7106aff to
4f21f2e
Compare
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Nov 6, 2020
…k@master networkservicemesh/sdk#572 networkservicemesh/sdk PR link: networkservicemesh/sdk#572 networkservicemesh/sdk commit message: commit 3216266046bdc8754e89b71add574fe84e947a46 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Fri Nov 6 22:18:09 2020 +0700 Get rid of nil filters for nsmgr (#572) * get rid of nil filters for nsmgr Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * fix issues after rebase Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Nov 6, 2020
…k@master networkservicemesh/sdk#572 networkservicemesh/sdk PR link: networkservicemesh/sdk#572 networkservicemesh/sdk commit message: commit 3216266046bdc8754e89b71add574fe84e947a46 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Fri Nov 6 22:18:09 2020 +0700 Get rid of nil filters for nsmgr (#572) * get rid of nil filters for nsmgr Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * fix issues after rebase Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Nov 6, 2020
…k@master networkservicemesh/sdk#572 networkservicemesh/sdk PR link: networkservicemesh/sdk#572 networkservicemesh/sdk commit message: commit 3216266046bdc8754e89b71add574fe84e947a46 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Fri Nov 6 22:18:09 2020 +0700 Get rid of nil filters for nsmgr (#572) * get rid of nil filters for nsmgr Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * fix issues after rebase Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Nov 6, 2020
…k@master networkservicemesh/sdk#572 networkservicemesh/sdk PR link: networkservicemesh/sdk#572 networkservicemesh/sdk commit message: commit 3216266046bdc8754e89b71add574fe84e947a46 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Fri Nov 6 22:18:09 2020 +0700 Get rid of nil filters for nsmgr (#572) * get rid of nil filters for nsmgr Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * fix issues after rebase Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Nov 6, 2020
…k@master networkservicemesh/sdk#572 networkservicemesh/sdk PR link: networkservicemesh/sdk#572 networkservicemesh/sdk commit message: commit 3216266046bdc8754e89b71add574fe84e947a46 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Fri Nov 6 22:18:09 2020 +0700 Get rid of nil filters for nsmgr (#572) * get rid of nil filters for nsmgr Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * fix issues after rebase Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vppagent
that referenced
this pull request
Nov 6, 2020
…k@master networkservicemesh/sdk#572 networkservicemesh/sdk PR link: networkservicemesh/sdk#572 networkservicemesh/sdk commit message: commit 3216266046bdc8754e89b71add574fe84e947a46 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Fri Nov 6 22:18:09 2020 +0700 Get rid of nil filters for nsmgr (#572) * get rid of nil filters for nsmgr Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * fix issues after rebase Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Nov 6, 2020
…k@master networkservicemesh/sdk#572 networkservicemesh/sdk PR link: networkservicemesh/sdk#572 networkservicemesh/sdk commit message: commit 3216266046bdc8754e89b71add574fe84e947a46 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Fri Nov 6 22:18:09 2020 +0700 Get rid of nil filters for nsmgr (#572) * get rid of nil filters for nsmgr Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * fix issues after rebase Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Nov 6, 2020
…k@master networkservicemesh/sdk#572 networkservicemesh/sdk PR link: networkservicemesh/sdk#572 networkservicemesh/sdk commit message: commit 3216266046bdc8754e89b71add574fe84e947a46 Author: Denis Tingaikin <49399980+denis-tingajkin@users.noreply.github.com> Date: Fri Nov 6 22:18:09 2020 +0700 Get rid of nil filters for nsmgr (#572) * get rid of nil filters for nsmgr Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * fix issues after rebase Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
illbegood
pushed a commit
to illbegood/sdk
that referenced
this pull request
Dec 20, 2020
* get rid of nil filters for nsmgr Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * fix issues after rebase Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
illbegood
pushed a commit
to illbegood/sdk
that referenced
this pull request
Dec 23, 2020
* get rid of nil filters for nsmgr Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * fix issues after rebase Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: denis-tingajkin denis.tingajkin@xored.com
Motivation
nil filters complicate the code