Explicitely close files for recvfd client *after* they don't matter. #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous we were allowing the recvfd files to be closed by their finalizer and the GC. This sometimes led to premature closing of files leading to errors like: networkservicemesh/cmd-forwarder-vppagent#187 'Delete' case. This fixes that by closing the files only after the ctx has is Done. Signed-off-by: Ed Warnicke <hagbard@gmail.com>
fkautz
approved these changes
Oct 20, 2020
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Oct 20, 2020
…k@master networkservicemesh/sdk#548 networkservicemesh/sdk PR link: networkservicemesh/sdk#548 networkservicemesh/sdk commit message: commit 8b0bd573228d24958ad9e74f643d083709e81844 Author: Ed Warnicke <hagbard@gmail.com> Date: Tue Oct 20 16:03:21 2020 -0500 Explicitely close files for recvfd client *after* they don't matter. (#548) Previous we were allowing the recvfd files to be closed by their finalizer and the GC. This sometimes led to premature closing of files leading to errors like: networkservicemesh/cmd-forwarder-vppagent#187 'Delete' case. This fixes that by closing the files only after the ctx has is Done. Signed-off-by: Ed Warnicke <hagbard@gmail.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Oct 20, 2020
…k@master networkservicemesh/sdk#548 networkservicemesh/sdk PR link: networkservicemesh/sdk#548 networkservicemesh/sdk commit message: commit 8b0bd573228d24958ad9e74f643d083709e81844 Author: Ed Warnicke <hagbard@gmail.com> Date: Tue Oct 20 16:03:21 2020 -0500 Explicitely close files for recvfd client *after* they don't matter. (#548) Previous we were allowing the recvfd files to be closed by their finalizer and the GC. This sometimes led to premature closing of files leading to errors like: networkservicemesh/cmd-forwarder-vppagent#187 'Delete' case. This fixes that by closing the files only after the ctx has is Done. Signed-off-by: Ed Warnicke <hagbard@gmail.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Oct 20, 2020
…k@master networkservicemesh/sdk#548 networkservicemesh/sdk PR link: networkservicemesh/sdk#548 networkservicemesh/sdk commit message: commit 8b0bd573228d24958ad9e74f643d083709e81844 Author: Ed Warnicke <hagbard@gmail.com> Date: Tue Oct 20 16:03:21 2020 -0500 Explicitely close files for recvfd client *after* they don't matter. (#548) Previous we were allowing the recvfd files to be closed by their finalizer and the GC. This sometimes led to premature closing of files leading to errors like: networkservicemesh/cmd-forwarder-vppagent#187 'Delete' case. This fixes that by closing the files only after the ctx has is Done. Signed-off-by: Ed Warnicke <hagbard@gmail.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Oct 20, 2020
…k@master networkservicemesh/sdk#548 networkservicemesh/sdk PR link: networkservicemesh/sdk#548 networkservicemesh/sdk commit message: commit 8b0bd573228d24958ad9e74f643d083709e81844 Author: Ed Warnicke <hagbard@gmail.com> Date: Tue Oct 20 16:03:21 2020 -0500 Explicitely close files for recvfd client *after* they don't matter. (#548) Previous we were allowing the recvfd files to be closed by their finalizer and the GC. This sometimes led to premature closing of files leading to errors like: networkservicemesh/cmd-forwarder-vppagent#187 'Delete' case. This fixes that by closing the files only after the ctx has is Done. Signed-off-by: Ed Warnicke <hagbard@gmail.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vppagent
that referenced
this pull request
Oct 20, 2020
…k@master networkservicemesh/sdk#548 networkservicemesh/sdk PR link: networkservicemesh/sdk#548 networkservicemesh/sdk commit message: commit 8b0bd573228d24958ad9e74f643d083709e81844 Author: Ed Warnicke <hagbard@gmail.com> Date: Tue Oct 20 16:03:21 2020 -0500 Explicitely close files for recvfd client *after* they don't matter. (#548) Previous we were allowing the recvfd files to be closed by their finalizer and the GC. This sometimes led to premature closing of files leading to errors like: networkservicemesh/cmd-forwarder-vppagent#187 'Delete' case. This fixes that by closing the files only after the ctx has is Done. Signed-off-by: Ed Warnicke <hagbard@gmail.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
edwarnicke
pushed a commit
to networkservicemesh/sdk-vppagent
that referenced
this pull request
Oct 21, 2020
…k@master networkservicemesh/sdk#548 (#407) networkservicemesh/sdk PR link: networkservicemesh/sdk#548 networkservicemesh/sdk commit message: commit 8b0bd573228d24958ad9e74f643d083709e81844 Author: Ed Warnicke <hagbard@gmail.com> Date: Tue Oct 20 16:03:21 2020 -0500 Explicitely close files for recvfd client *after* they don't matter. (#548) Previous we were allowing the recvfd files to be closed by their finalizer and the GC. This sometimes led to premature closing of files leading to errors like: networkservicemesh/cmd-forwarder-vppagent#187 'Delete' case. This fixes that by closing the files only after the ctx has is Done. Signed-off-by: Ed Warnicke <hagbard@gmail.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
illbegood
pushed a commit
to illbegood/sdk
that referenced
this pull request
Dec 20, 2020
…etworkservicemesh#548) Previous we were allowing the recvfd files to be closed by their finalizer and the GC. This sometimes led to premature closing of files leading to errors like: networkservicemesh/cmd-forwarder-vppagent#187 'Delete' case. This fixes that by closing the files only after the ctx has is Done. Signed-off-by: Ed Warnicke <hagbard@gmail.com> Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous we were allowing the recvfd files to be closed by their
finalizer and the GC.
This sometimes led to premature closing of files leading to errors like:
networkservicemesh/cmd-forwarder-vppagent#187
'Delete' case. This fixes that by closing the files only after the
ctx has is Done.
Signed-off-by: Ed Warnicke hagbard@gmail.com