Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to expose Prometheus metrics via http/s server #1653

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Add an option to expose Prometheus metrics via http/s server #1653

merged 1 commit into from
Aug 19, 2024

Conversation

bszirtes
Copy link
Contributor

@bszirtes bszirtes commented Jul 29, 2024 •
edited
Loading

Description

Added a new server that can be utilized to expose Prometheus metrics on via http or https.

Issue link

#1652

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@bszirtes bszirtes force-pushed the prometheus-without-otel branch 5 times, most recently from 15d5a79 to 33e8310 Compare July 31, 2024 09:52
denis-tingaikin
denis-tingaikin reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can add a separate option to export prometheus metrics.

Question: Have you tried to use https://opentelemetry.io/docs/languages/js/exporters/#use-otlp-exporter-with-httpjson-or-httpprotobuf?

Just wondering what other benefits there are to running it as a separate HTTP server.

@bszirtes
Copy link
Contributor Author

bszirtes commented Aug 6, 2024

Hi @denis-tingaikin,

As I understand our situation, we intend to have an option to completely eliminate the usage of OpenTelemetry in our solution.

@denis-tingaikin
Copy link
Member

OK, that makes sense to me, and as I recall, @edwarnicke agrees to add a separate option for exporting metrics. 

Currently, we're thinking about the technical and design parts of the solution since we'll need to apply it for all repositories. I'll return back with more details in a few days.

@bszirtes bszirtes force-pushed the prometheus-without-otel branch 2 times, most recently from 5bdce7f to cf3bb3a Compare August 7, 2024 12:38
denis-tingaikin
denis-tingaikin reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move all code related to prometheus outside of opentelemtry pkg? Say  pkg/tools/prometheus?

@bszirtes bszirtes force-pushed the prometheus-without-otel branch 2 times, most recently from b9fa637 to 2a7504b Compare August 14, 2024 14:57
@bszirtes
Copy link
Contributor Author

Hi @denis-tingaikin,

I've moved the Prometheus-related code to a new directory, as you suggested.

@bszirtes
Add an option to expose Prometheus metrics via http/s server
6a2c6de 
Signed-off-by: Botond Szirtes <botond.szirtes@est.tech>
@bszirtes
Copy link
Contributor Author

Hi @denis-tingaikin,

I've moved the ListernAndServe function here, as you suggested.

denis-tingaikin
denis-tingaikin approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

denis-tingaikin
denis-tingaikin approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge these.

If you get any comments, please feel free to leave them here, and we'll respond in a separate PR.

@denis-tingaikin denis-tingaikin merged commit ae25bb4 into networkservicemesh:main Aug 19, 2024
15 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Aug 19, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ab6d926 
…k@main

PR link: networkservicemesh/sdk#1653

Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
  - Add an option to expose Prometheus metrics via http/s server (#1653)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Aug 19, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
00782e5 
…k@main

PR link: networkservicemesh/sdk#1653

Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
  - Add an option to expose Prometheus metrics via http/s server (#1653)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/sdk-ovs that referenced this pull request Aug 19, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
96d6eee 
…k-sriov@main (#337)

PR link: networkservicemesh/sdk-sriov#607

Commit: 8447a4a
Author: Network Service Mesh Bot
Date: 2024-08-19 04:36:21 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#607)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
        - Add an option to expose Prometheus metrics via http/s server (#1653)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/cmd-nsc-vpp that referenced this pull request Aug 19, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
daa6a86 
…k-vpp@main (#710)

PR link: networkservicemesh/sdk-vpp#846

Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
        - Add an option to expose Prometheus metrics via http/s server (#1653)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/cmd-nse-firewall-vpp that referenced this pull request Aug 19, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
265e7b3 
…k-vpp@main (#528)

PR link: networkservicemesh/sdk-vpp#846

Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
        - Add an option to expose Prometheus metrics via http/s server (#1653)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/cmd-lb-vl3-vpp that referenced this pull request Aug 19, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2c40dbd 
…k-vpp@main (#94)

PR link: networkservicemesh/sdk-vpp#846

Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
        - Add an option to expose Prometheus metrics via http/s server (#1653)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/cmd-nse-vl3-vpp that referenced this pull request Aug 19, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
29e4444 
…k-vpp@main (#355)

PR link: networkservicemesh/sdk-vpp#846

Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
        - Add an option to expose Prometheus metrics via http/s server (#1653)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 19, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
71146da 
…d-nsc-vpp@main

PR link: networkservicemesh/cmd-nsc-vpp#710

Commit: daa6a86
Author: Network Service Mesh Bot
Date: 2024-08-19 04:40:36 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#710)
PR link: networkservicemesh/sdk-vpp#846
Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
                - Add an option to expose Prometheus metrics via http/s server (#1653)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 19, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
bce84a3 
…d-registry-k8s@main (#12237)

PR link: networkservicemesh/cmd-registry-k8s#473

Commit: 0c420bc
Author: Network Service Mesh Bot
Date: 2024-08-19 04:39:15 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#473)
PR link: networkservicemesh/sdk-k8s#519
Commit: ad1418d
Author: Network Service Mesh Bot
Date: 2024-08-19 04:35:26 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#519)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
        - Add an option to expose Prometheus metrics via http/s server (#1653)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/cmd-nse-icmp-responder-vpp that referenced this pull request Aug 19, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b55c797 
…k-vpp@main (#692)

PR link: networkservicemesh/sdk-vpp#846

Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
        - Add an option to expose Prometheus metrics via http/s server (#1653)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 19, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
3b6c45b 
…d-admission-webhook-k8s@main (#12238)

PR link: networkservicemesh/cmd-admission-webhook-k8s#454

Commit: 0fd3d20
Author: Network Service Mesh Bot
Date: 2024-08-19 04:39:17 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#454)
PR link: networkservicemesh/sdk-k8s#519
Commit: ad1418d
Author: Network Service Mesh Bot
Date: 2024-08-19 04:35:26 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#519)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
        - Add an option to expose Prometheus metrics via http/s server (#1653)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/cmd-nsc-simple-docker that referenced this pull request Aug 19, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ff493fb 
…k-vpp@main (#244)

PR link: networkservicemesh/sdk-vpp#846

Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
        - Add an option to expose Prometheus metrics via http/s server (#1653)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 19, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
762b7c3 
…d-nse-firewall-vpp@main

PR link: networkservicemesh/cmd-nse-firewall-vpp#528

Commit: 265e7b3
Author: Network Service Mesh Bot
Date: 2024-08-19 04:40:48 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#528)
PR link: networkservicemesh/sdk-vpp#846
Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
                - Add an option to expose Prometheus metrics via http/s server (#1653)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-ovs that referenced this pull request Aug 19, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ac008b6 
…k-ovs@main

PR link: networkservicemesh/sdk-ovs#337

Commit: 96d6eee
Author: Network Service Mesh Bot
Date: 2024-08-19 04:40:35 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#337)
PR link: networkservicemesh/sdk-sriov#607
Commit: 8447a4a
Author: Network Service Mesh Bot
Date: 2024-08-19 04:36:21 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#607)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
                - Add an option to expose Prometheus metrics via http/s server (#1653)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/cmd-nse-simple-vl3-docker that referenced this pull request Aug 19, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
98bcdae 
…k-vpp@main (#258)

PR link: networkservicemesh/sdk-vpp#846

Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
        - Add an option to expose Prometheus metrics via http/s server (#1653)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 19, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
2848687 
…d-nse-vl3-vpp@main

PR link: networkservicemesh/cmd-nse-vl3-vpp#355

Commit: 29e4444
Author: Network Service Mesh Bot
Date: 2024-08-19 04:40:54 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#355)
PR link: networkservicemesh/sdk-vpp#846
Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
                - Add an option to expose Prometheus metrics via http/s server (#1653)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 19, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
da238a6 
…d-nse-icmp-responder-vpp@main

PR link: networkservicemesh/cmd-nse-icmp-responder-vpp#692

Commit: b55c797
Author: Network Service Mesh Bot
Date: 2024-08-19 04:40:58 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#692)
PR link: networkservicemesh/sdk-vpp#846
Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
                - Add an option to expose Prometheus metrics via http/s server (#1653)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 19, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
56a0544 
…d-lb-vl3-vpp@main

PR link: networkservicemesh/cmd-lb-vl3-vpp#94

Commit: 2c40dbd
Author: Network Service Mesh Bot
Date: 2024-08-19 04:40:52 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#94)
PR link: networkservicemesh/sdk-vpp#846
Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
                - Add an option to expose Prometheus metrics via http/s server (#1653)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 19, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
28ef3fb 
…d-nsc-simple-docker@main

PR link: networkservicemesh/cmd-nsc-simple-docker#244

Commit: ff493fb
Author: Network Service Mesh Bot
Date: 2024-08-19 04:41:09 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#244)
PR link: networkservicemesh/sdk-vpp#846
Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
                - Add an option to expose Prometheus metrics via http/s server (#1653)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 19, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
9da4c08 
…d-nse-simple-vl3-docker@main

PR link: networkservicemesh/cmd-nse-simple-vl3-docker#258

Commit: 98bcdae
Author: Network Service Mesh Bot
Date: 2024-08-19 04:41:23 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#258)
PR link: networkservicemesh/sdk-vpp#846
Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
                - Add an option to expose Prometheus metrics via http/s server (#1653)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 19, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
bd50a80 
…d-lb-vl3-vpp@main (#12112)

PR link: networkservicemesh/cmd-lb-vl3-vpp#94

Commit: 2c40dbd
Author: Network Service Mesh Bot
Date: 2024-08-19 04:40:52 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#94)
PR link: networkservicemesh/sdk-vpp#846
Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
                - Add an option to expose Prometheus metrics via http/s server (#1653)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 19, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
d39c96f 
…d-nse-icmp-responder-vpp@main (#12148)

PR link: networkservicemesh/cmd-nse-icmp-responder-vpp#692

Commit: b55c797
Author: Network Service Mesh Bot
Date: 2024-08-19 04:40:58 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#692)
PR link: networkservicemesh/sdk-vpp#846
Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
                - Add an option to expose Prometheus metrics via http/s server (#1653)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/cmd-forwarder-sriov that referenced this pull request Aug 19, 2024
@nsmbot
Update from update/networkservicemesh/sdk-sriov (#763)
7d0b81d 
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main
PR link: networkservicemesh/sdk-sriov#607

Commit: 8447a4a
Author: Network Service Mesh Bot
Date: 2024-08-19 04:36:21 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#607)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
        - Add an option to expose Prometheus metrics via http/s server (#1653)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

* Automatically resolving conflicts in go.mod and updating dependency versions to the latest

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 19, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
2130454 
…d-forwarder-sriov@main

PR link: networkservicemesh/cmd-forwarder-sriov#763

Commit: 7d0b81d
Author: Network Service Mesh Bot
Date: 2024-08-19 04:42:45 -0500
Message:
  - Update from update/networkservicemesh/sdk-sriov (#763)
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main
PR link: networkservicemesh/sdk-sriov#607
Commit: 8447a4a
Author: Network Service Mesh Bot
Date: 2024-08-19 04:36:21 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#607)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
                - Add an option to expose Prometheus metrics via http/s server (#1653)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
* Automatically resolving conflicts in go.mod and updating dependency versions to the latest
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
---------
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/cmd-nse-vlan-vpp that referenced this pull request Aug 19, 2024
@nsmbot
Update from update/networkservicemesh/sdk-vpp (#499)
8ad5593 
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main
PR link: networkservicemesh/sdk-vpp#846

Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
        - Add an option to expose Prometheus metrics via http/s server (#1653)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

* Automatically resolving conflicts in go.mod and updating dependency versions to the latest

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 19, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
45ad1b1 
…d-forwarder-sriov@main (#12239)

PR link: networkservicemesh/cmd-forwarder-sriov#763

Commit: 7d0b81d
Author: Network Service Mesh Bot
Date: 2024-08-19 04:42:45 -0500
Message:
  - Update from update/networkservicemesh/sdk-sriov (#763)
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main
PR link: networkservicemesh/sdk-sriov#607
Commit: 8447a4a
Author: Network Service Mesh Bot
Date: 2024-08-19 04:36:21 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#607)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
                - Add an option to expose Prometheus metrics via http/s server (#1653)

* Automatically resolving conflicts in go.mod and updating dependency versions to the latest

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 19, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
1856b08 
…d-nse-vlan-vpp@main

PR link: networkservicemesh/cmd-nse-vlan-vpp#499

Commit: 8ad5593
Author: Network Service Mesh Bot
Date: 2024-08-19 04:44:07 -0500
Message:
  - Update from update/networkservicemesh/sdk-vpp (#499)
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main
PR link: networkservicemesh/sdk-vpp#846
Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
                - Add an option to expose Prometheus metrics via http/s server (#1653)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
* Automatically resolving conflicts in go.mod and updating dependency versions to the latest
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
---------
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/cmd-forwarder-ovs that referenced this pull request Aug 19, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/sd…
03766fb 
…k-ovs@main (#403)

PR link: networkservicemesh/sdk-ovs#337

Commit: 96d6eee
Author: Network Service Mesh Bot
Date: 2024-08-19 04:40:35 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#337)
PR link: networkservicemesh/sdk-sriov#607
Commit: 8447a4a
Author: Network Service Mesh Bot
Date: 2024-08-19 04:36:21 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#607)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
                - Add an option to expose Prometheus metrics via http/s server (#1653)

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 19, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
2c27850 
…d-forwarder-ovs@main

PR link: networkservicemesh/cmd-forwarder-ovs#403

Commit: 03766fb
Author: Network Service Mesh Bot
Date: 2024-08-19 04:44:32 -0500
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/sdk-ovs@main (#403)
PR link: networkservicemesh/sdk-ovs#337
Commit: 96d6eee
Author: Network Service Mesh Bot
Date: 2024-08-19 04:40:35 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#337)
PR link: networkservicemesh/sdk-sriov#607
Commit: 8447a4a
Author: Network Service Mesh Bot
Date: 2024-08-19 04:36:21 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#607)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
                - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
                                - Add an option to expose Prometheus metrics via http/s server (#1653)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Aug 19, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
11b6bce 
…d-nse-vlan-vpp@main (#12231)

PR link: networkservicemesh/cmd-nse-vlan-vpp#499

Commit: 8ad5593
Author: Network Service Mesh Bot
Date: 2024-08-19 04:44:07 -0500
Message:
  - Update from update/networkservicemesh/sdk-vpp (#499)
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main
PR link: networkservicemesh/sdk-vpp#846
Commit: 12509d5
Author: Network Service Mesh Bot
Date: 2024-08-19 04:37:08 -0500
Message:
    - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#846)
PR link: networkservicemesh/sdk-kernel#676
Commit: 64ed683
Author: Network Service Mesh Bot
Date: 2024-08-19 04:33:21 -0500
Message:
        - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#676)
PR link: networkservicemesh/sdk#1653
Commit: ae25bb4
Author: Botond Szirtes
Date: 2024-08-19 11:30:36 +0200
Message:
                - Add an option to expose Prometheus metrics via http/s server (#1653)

* Automatically resolving conflicts in go.mod and updating dependency versions to the latest

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
denis-tingaikin pushed a commit that referenced this pull request Sep 17, 2024
@bszirtes @denis-tingaikin
Add an option to expose Prometheus metrics via http/s server (#1653)
99c75ea 
Signed-off-by: Botond Szirtes <botond.szirtes@est.tech>
denis-tingaikin pushed a commit that referenced this pull request Sep 17, 2024
@bszirtes @denis-tingaikin
Add an option to expose Prometheus metrics via http/s server (#1653)
b9a63dc 
Signed-off-by: Botond Szirtes <botond.szirtes@est.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@Ex4amp1e Ex4amp1e Awaiting requested review from Ex4amp1e

@NikitaSkrynnik NikitaSkrynnik Awaiting requested review from NikitaSkrynnik

@robaganrab robaganrab Awaiting requested review from robaganrab

@edwarnicke edwarnicke Awaiting requested review from edwarnicke

@ljkiraly ljkiraly Awaiting requested review from ljkiraly

@szvincze szvincze Awaiting requested review from szvincze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bszirtes @denis-tingaikin