-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some leaks in authorize chain elements #1623
Merged
denis-tingaikin
merged 5 commits into
networkservicemesh:main
from
NikitaSkrynnik:authorize-leaks
May 16, 2024
Merged
Fix some leaks in authorize chain elements #1623
denis-tingaikin
merged 5 commits into
networkservicemesh:main
from
NikitaSkrynnik:authorize-leaks
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, LGTM
It seems like we have access to the SpffeIDConnectionMap
, so we can add a few unit tests and make sure that in problem scenarios, the map has the expected count. It may also avoid regressions in future.
VitalyGushin
approved these changes
May 15, 2024
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
force-pushed
the
authorize-leaks
branch
4 times, most recently
from
May 16, 2024 06:41
ab14ff3
to
0bc6ca2
Compare
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik
force-pushed
the
authorize-leaks
branch
from
May 16, 2024 07:02
0bc6ca2
to
a5b27c8
Compare
denis-tingaikin
approved these changes
May 16, 2024
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
May 16, 2024
…k@main PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add tests for memory leaks Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
May 16, 2024
…k@main PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add tests for memory leaks Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
May 16, 2024
…k@main PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add tests for memory leaks Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
May 16, 2024
…k@main PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add tests for memory leaks Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
May 16, 2024
…k@main PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add tests for memory leaks Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
May 16, 2024
…k@main PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add tests for memory leaks Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-dashboard-backend
that referenced
this pull request
May 16, 2024
…k@main PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add tests for memory leaks Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
May 16, 2024
…k@main PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add tests for memory leaks Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
May 16, 2024
…k@main PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add tests for memory leaks Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
May 16, 2024
…k@main PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add tests for memory leaks Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
May 16, 2024
…k@main PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add tests for memory leaks Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
May 16, 2024
…k@main PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add tests for memory leaks Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
May 16, 2024
…k@main PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add tests for memory leaks Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
May 16, 2024
…k@main PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * add tests for memory leaks Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * fix go linter issues Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 16, 2024
…d-nse-simple-vl3-docker@main PR link: networkservicemesh/cmd-nse-simple-vl3-docker#242 Commit: fa72451 Author: Network Service Mesh Bot Date: 2024-05-16 03:09:13 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#242) PR link: networkservicemesh/sdk-vpp#829 Commit: 9bdb057 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:49 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#829) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/cmd-nse-vl3-vpp
that referenced
this pull request
May 16, 2024
…k-vpp@main (#338) PR link: networkservicemesh/sdk-vpp#829 Commit: 9bdb057 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:49 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#829) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/sdk-ovs
that referenced
this pull request
May 16, 2024
…k-sriov@main (#325) PR link: networkservicemesh/sdk-sriov#594 Commit: 7fee1a7 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:40 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#594) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
May 16, 2024
…k-vpp@main (#693) PR link: networkservicemesh/sdk-vpp#829 Commit: 9bdb057 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:49 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#829) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 16, 2024
…d-nse-firewall-vpp@main PR link: networkservicemesh/cmd-nse-firewall-vpp#511 Commit: 2194c7d Author: Network Service Mesh Bot Date: 2024-05-16 03:09:17 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#511) PR link: networkservicemesh/sdk-vpp#829 Commit: 9bdb057 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:49 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#829) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/cmd-nsc-simple-docker
that referenced
this pull request
May 16, 2024
…k-vpp@main (#228) PR link: networkservicemesh/sdk-vpp#829 Commit: 9bdb057 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:49 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#829) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 16, 2024
…d-nse-vlan-vpp@main PR link: networkservicemesh/cmd-nse-vlan-vpp#474 Commit: aea878b Author: Network Service Mesh Bot Date: 2024-05-16 03:09:16 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#474) PR link: networkservicemesh/sdk-vpp#829 Commit: 9bdb057 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:49 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#829) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 16, 2024
…d-nse-icmp-responder-vpp@main PR link: networkservicemesh/cmd-nse-icmp-responder-vpp#674 Commit: 5e18208 Author: Network Service Mesh Bot Date: 2024-05-16 03:09:20 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#674) PR link: networkservicemesh/sdk-vpp#829 Commit: 9bdb057 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:49 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#829) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
May 16, 2024
…k-sriov@main (#596) PR link: networkservicemesh/sdk-sriov#594 Commit: 7fee1a7 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:40 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#594) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 16, 2024
…d-lb-vl3-vpp@main PR link: networkservicemesh/cmd-lb-vl3-vpp#77 Commit: efc866b Author: Network Service Mesh Bot Date: 2024-05-16 03:09:21 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#77) PR link: networkservicemesh/sdk-vpp#829 Commit: 9bdb057 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:49 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#829) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 16, 2024
…d-nsc-init@main PR link: networkservicemesh/cmd-nsc-init#748 Commit: d51d2f9 Author: Network Service Mesh Bot Date: 2024-05-16 03:09:23 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#748) PR link: networkservicemesh/sdk-sriov#594 Commit: 7fee1a7 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:40 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#594) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 16, 2024
…d-nse-vl3-vpp@main PR link: networkservicemesh/cmd-nse-vl3-vpp#338 Commit: 85288b9 Author: Network Service Mesh Bot Date: 2024-05-16 03:09:33 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#338) PR link: networkservicemesh/sdk-vpp#829 Commit: 9bdb057 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:49 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#829) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 16, 2024
…d-nsc-vpp@main PR link: networkservicemesh/cmd-nsc-vpp#693 Commit: 6b9b28b Author: Network Service Mesh Bot Date: 2024-05-16 03:09:35 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#693) PR link: networkservicemesh/sdk-vpp#829 Commit: 9bdb057 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:49 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#829) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced May 16, 2024
Merged
Merged
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 16, 2024
…d-nsc-simple-docker@main PR link: networkservicemesh/cmd-nsc-simple-docker#228 Commit: c64c3aa Author: Network Service Mesh Bot Date: 2024-05-16 03:09:37 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#228) PR link: networkservicemesh/sdk-vpp#829 Commit: 9bdb057 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:49 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#829) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 16, 2024
…d-nse-icmp-responder@main PR link: networkservicemesh/cmd-nse-icmp-responder#596 Commit: 5dcf90e Author: Network Service Mesh Bot Date: 2024-05-16 03:09:44 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#596) PR link: networkservicemesh/sdk-sriov#594 Commit: 7fee1a7 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:40 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#594) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 16, 2024
…d-forwarder-sriov@main (#11985) PR link: networkservicemesh/cmd-forwarder-sriov#736 Commit: 2d5e743 Author: Network Service Mesh Bot Date: 2024-05-16 03:08:58 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#736) PR link: networkservicemesh/sdk-sriov#594 Commit: 7fee1a7 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:40 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#594) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-ovs
that referenced
this pull request
May 16, 2024
…k-ovs@main PR link: networkservicemesh/sdk-ovs#325 Commit: 7b7abbb Author: Network Service Mesh Bot Date: 2024-05-16 03:09:34 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#325) PR link: networkservicemesh/sdk-sriov#594 Commit: 7fee1a7 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:40 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#594) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 16, 2024
…d-lb-vl3-vpp@main (#12009) PR link: networkservicemesh/cmd-lb-vl3-vpp#77 Commit: efc866b Author: Network Service Mesh Bot Date: 2024-05-16 03:09:21 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#77) PR link: networkservicemesh/sdk-vpp#829 Commit: 9bdb057 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:49 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#829) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 16, 2024
…d-nse-icmp-responder-vpp@main (#12011) PR link: networkservicemesh/cmd-nse-icmp-responder-vpp#674 Commit: 5e18208 Author: Network Service Mesh Bot Date: 2024-05-16 03:09:20 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main (#674) PR link: networkservicemesh/sdk-vpp#829 Commit: 9bdb057 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:49 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#829) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 16, 2024
…d-nsc-init@main (#12010) PR link: networkservicemesh/cmd-nsc-init#748 Commit: d51d2f9 Author: Network Service Mesh Bot Date: 2024-05-16 03:09:23 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#748) PR link: networkservicemesh/sdk-sriov#594 Commit: 7fee1a7 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:40 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#594) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
May 16, 2024
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main PR link: networkservicemesh/sdk-sriov#594 Commit: 7fee1a7 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:40 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#594) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> * Automatically resolving conflicts in go.mod and updating dependency versions to the latest Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 16, 2024
…d-nse-vlan-vpp@main PR link: networkservicemesh/cmd-nse-vlan-vpp#475 Commit: 45cbade Author: Network Service Mesh Bot Date: 2024-05-16 03:12:16 -0500 Message: - Update from update/networkservicemesh/sdk-sriov (#475) * Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main PR link: networkservicemesh/sdk-sriov#594 Commit: 7fee1a7 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:40 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#594) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> * Automatically resolving conflicts in go.mod and updating dependency versions to the latest Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/cmd-forwarder-ovs
that referenced
this pull request
May 16, 2024
…k-ovs@main (#378) PR link: networkservicemesh/sdk-ovs#325 Commit: 7b7abbb Author: Network Service Mesh Bot Date: 2024-05-16 03:09:34 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#325) PR link: networkservicemesh/sdk-sriov#594 Commit: 7fee1a7 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:40 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#594) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
added a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 16, 2024
…d-nse-vlan-vpp@main (#12008) PR link: networkservicemesh/cmd-nse-vlan-vpp#475 Commit: 45cbade Author: Network Service Mesh Bot Date: 2024-05-16 03:12:16 -0500 Message: - Update from update/networkservicemesh/sdk-sriov (#475) * Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main PR link: networkservicemesh/sdk-sriov#594 Commit: 7fee1a7 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:40 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#594) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- * Automatically resolving conflicts in go.mod and updating dependency versions to the latest --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
May 16, 2024
…d-forwarder-ovs@main PR link: networkservicemesh/cmd-forwarder-ovs#378 Commit: ca4adb2 Author: Network Service Mesh Bot Date: 2024-05-16 03:13:35 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-ovs@main (#378) PR link: networkservicemesh/sdk-ovs#325 Commit: 7b7abbb Author: Network Service Mesh Bot Date: 2024-05-16 03:09:34 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#325) PR link: networkservicemesh/sdk-sriov#594 Commit: 7fee1a7 Author: Network Service Mesh Bot Date: 2024-05-16 03:05:40 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#594) PR link: networkservicemesh/sdk-kernel#663 Commit: 6a362bb Author: Network Service Mesh Bot Date: 2024-05-16 03:01:48 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#663) PR link: networkservicemesh/sdk#1623 Commit: 3b79590 Author: Nikita Skrynnik Date: 2024-05-16 18:55:35 +1100 Message: - Fix some leaks in authorize chain elements (#1623) * fix some leaks in authorize chain elements * fix go linter issues * add tests for memory leaks * fix go linter issues * rerun CI --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manage values in sync maps a bit better in case of errors
Issue link
#1621
How Has This Been Tested?
Types of changes