Authn chain elements #154
Closed
Authn chain elements #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 27, 2020 13:59
Signed-off-by: Ilya Lobkov <ilya.lobkov@xored.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@xored.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@xored.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@xored.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@xored.com>
|
@edwarnicke I think this PR can be useful for Advanced OPA Policies. Can you please take a look? |
edwarnicke
reviewed
Apr 6, 2020
| } | ||
|
|
||
| token := request.GetConnection().GetPath().GetPathSegments()[request.GetConnection().GetPath().GetIndex()].GetToken() | ||
| if err := security.VerifyToken(token, x509crt); err != nil { |
There was a problem hiding this comment.
Can't we do the token verification in OPA?
There was a problem hiding this comment.
I think it is a good idea, will do :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #152
Description
Add 2 chain elements:
AuthnClientadds token to the currentPathSegment(pointed byIndex)AuthnSerververifies token of the currentPathSegment