Remove debug.Stack() from logger

[glazychev-art]

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

It seems we don't actually need debug.Stack(), because errors.New() already has a stack:

// New, Errorf, Wrap, and Wrapf record a stack trace at the point they are
// invoked. This information can be retrieved with the following interface:
//
//     type stackTracer interface {
//             StackTrace() errors.StackTrace
//     }

Even if we create error without using errors package, trace chain element will wrap it to the struct with stack trace (errors.Wrapf(...)).

We do not need to call debug.Stack() for every Errorf() call, because we already have this information.
And we need to set "%+v" if we want to print error with stack trace - link

Issue link

networkservicemesh/deployments-k8s#2368

How Has This Been Tested?

• Added unit testing to cover
• Tested manually
• Tested by integration testing
• Have not tested

Types of changes

• Bug fix
• New functionallity
• Documentation
• Refactoring
• CI

[glazychev-art]

There are several cases if error happen:

1. Print stack trace for each chain element:
   + full info about an error (including line number)
   - a huge number of duplicate logs
2. Print only if the error hasn't stack trace (current behavior in trace chain element):
   + for some cases we print a stack trace only once
   - if the error already has a stack trace, we don't print it

[glazychev-art]

@edwarnicke
Do you have any thoughts on this?

[denis-tingaikin]

I think we can try this and if it will make logs not informative then we can revert this patch and consider another solution.