Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next::Client doesn't work with chained elements #172

Closed
lazyniv opened this issue Mar 31, 2020 · 1 comment
Closed

next::Client doesn't work with chained elements #172

lazyniv opened this issue Mar 31, 2020 · 1 comment
Assignees
@denis-tingaikin
Labels
bug Something isn't working

Comments

@lazyniv
Copy link
Member

lazyniv commented Mar 31, 2020

Motivation

When we pass the chained client element into next.NewNetworkServiceClient(), unexpected behaviour may occur in next.Request -- it will be impossible to make request through all the clients in the chain.
@denis-tingaikin denis-tingaikin self-assigned this Mar 31, 2020
@denis-tingaikin denis-tingaikin added the bug Something isn't working label Mar 31, 2020
denis-tingaikin added a commit to denis-tingaikin/sdk that referenced this issue Mar 31, 2020
@denis-tingaikin
fix issue networkservicemesh#172
086f019 
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
@denis-tingaikin denis-tingaikin mentioned this issue Mar 31, 2020
Merged
@lazyniv lazyniv mentioned this issue Mar 31, 2020
Merged
edwarnicke pushed a commit that referenced this issue Apr 3, 2020
@denis-tingaikin
Add the possible to make chain of chains via pkg/next (#173)
fd5d675 
* fix issue #172

Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>

* fix format

Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>

* review comments

Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>

* fix nil context passing case

Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>

* self code review

Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
@denis-tingaikin
Copy link
Member

Fixed by #173

nsmbot pushed a commit that referenced this issue Mar 25, 2024
Update go.mod and go.sum to latest version from networkservicemesh/ap…
2398c8c 
…i@main

PR link: networkservicemesh/api#172

Commit: 92facbc
Author: Nikita Skrynnik
Date: 2024-03-25 17:44:51 +0700
Message:
  - fix CVEs (#172)
* fix CVEs

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* go mod tidy

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
denis-tingaikin pushed a commit that referenced this issue Mar 25, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/ap…
d2fe843 
…i@main (#1600)

PR link: networkservicemesh/api#172

Commit: 92facbc
Author: Nikita Skrynnik
Date: 2024-03-25 17:44:51 +0700
Message:
  - fix CVEs (#172)
* fix CVEs



* go mod tidy



---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denis-tingaikin denis-tingaikin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lazyniv @denis-tingaikin