#29 Metrics for vpp agent #136
Conversation
|
@edwarnicke I'm still not fully sure how it works, since working on docker integration tests for this case. Hope will finish today. |
|
PR with support for on-demand stats: ligato/vpp-agent#1634 |
|
Thanks @ondrej-fabry, 0-interval will be ideal case for us. |
|
@ondrej-fabry Any idea when 3.0.x with 0-interval will be available? Thanks. |
|
Will release new version this week. |
|
@haiodo I just released version 3.1.0. Full changelog: https://github.com/ligato/vpp-agent/blob/v3.1.0/CHANGELOG.md#v3.1.0 |
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Correct logging Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Update to latest vppagent Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
|
@edwarnicke it is updated for few time ago, could you please take a look on a moment. Thanks. |
| } | ||
|
|
||
| // NewServer creates a new metrics collector instance | ||
| func NewServer(vppClient configurator.StatsPollerServiceClient) networkservice.NetworkServiceServer { |
There was a problem hiding this comment.
Could we using a grpc.ClientConnInterface hre instead of passing in the client itself, see: https://github.com/networkservicemesh/sdk-vppagent/blob/master/pkg/networkservice/commit/client.go#L43
The reason being that, when we put together a chain, we can use the same vppAgentCC for both commit and metrics :)
There was a problem hiding this comment.
Sure, let me update PR.
There was a problem hiding this comment.
Actually... just realized when I went to try to do this with heal that it can make testing much harder. Feel free to ignore this comment.
#29 Metrics chain element for vpp agent.