Rename interfaces back on connection close #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bolodya1997
force-pushed
the
fix
branch
17 times, most recently
from
76e6997 to
697a6e8
Compare
haiodo
reviewed
Dec 2, 2020
added 4 commits
December 2, 2020 16:04
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Bolodya1997
force-pushed
the
fix
branch
2 times, most recently
from
f23a3b7 to
70390bb
Compare
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
haiodo
approved these changes
Dec 8, 2020
nsmbot
pushed a commit
to networkservicemesh/sdk-sriov
that referenced
this pull request
Dec 8, 2020
…k-kernel@master networkservicemesh/sdk-kernel#72 networkservicemesh/sdk-kernel PR link: networkservicemesh/sdk-kernel#72 networkservicemesh/sdk-kernel commit message: commit 42a3594b529259db6bb92ff745cad25adbce721a Author: Andrey Sobolev <haiodo@users.noreply.github.com> Date: Tue Dec 8 16:49:30 2020 +0700 Merge pull request #72 from Bolodya1997/fix Rename interfaces back on connection close Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
After the connection close, kernel interface still has new name. If client returns and forwarder tries to select another VF for the client, it can result in naming collisions.
Solution
Keep renames mapping, revert renames on failure/close.