Improved recovery for policy base routing #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljkiraly
force-pushed
the
pbr-sync-table-key
branch
from
7587ee6 to
8a9f7c9
Compare
Related issue: networkservicemesh/deployments-k8s/9463 Fix for faulty ip rules after forwarder restart Using proper key in internal Map for routing table IDs; Ensure that the routing table belongs to the link handled by NSM; At policy recovery do not flush the routing table if more than one rule reffering to it, deleting the last rule with reference to a given routing table will flush the table. Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
ljkiraly
force-pushed
the
pbr-sync-table-key
branch
from
8a9f7c9 to
6a9ccb5
Compare
|
Hi @denis-tingaikin, @edwarnicke, Now this issue is a highest priority one for us and because of the time pressure it is not an option to wait for NSM v1.10.0 release. Thus, we are planning to use a fork that contains the very same fix on top of NSM v1.9.0. Due to this reason it would be crucial to have it reviewed as soon as possible to be able to backport the final version that will be part of the coming NSM release, to keep it compatible for the future upgrade. Can you please prioritize the review of this fix? |
denis-tingaikin
approved these changes
Jul 6, 2023
nsmbot
pushed a commit
to networkservicemesh/sdk-sriov
that referenced
this pull request
Jul 8, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#598 Commit: 891e1f8 Author: Denis Tingaikin Date: 2023-07-08 03:09:54 +0300 Message: - Merge pull request #598 from Nordix/pbr-sync-table-key Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-l7-proxy
that referenced
this pull request
Jul 8, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#598 Commit: 891e1f8 Author: Denis Tingaikin Date: 2023-07-08 03:09:54 +0300 Message: - Merge pull request #598 from Nordix/pbr-sync-table-key Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Jul 8, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#598 Commit: 891e1f8 Author: Denis Tingaikin Date: 2023-07-08 03:09:54 +0300 Message: - Merge pull request #598 from Nordix/pbr-sync-table-key Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
|
Merging this since its ASAP @glazychev-art feel free to add comments and we could resolve them in the separate PR. |
This was referenced Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: networkservicemesh/deployments-k8s/issues/9463
Fix for faulty ip rules after forwarder restart
Using proper key in internal Map for routing table IDs; Ensure that the routing table belongs to the link handled by NSM; At policy recovery do not flush the routing table if more than one rule reffering to it,
deleting the last rule with reference to a given routing table will flush the table.