Update to go 1.20 #591
Merged
Update to go 1.20 #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LionelJouin
force-pushed
the
go120
branch
2 times, most recently
from
cce4fc9 to
f7216d6
Compare
|
@LionelJouin Do you have an idea on how to fix linter issues? |
|
@denis-tingaikin From what I saw it was depguard, should I disable it or reconfigure it? |
|
@LionelJouin I'd prefered to fix depguard, but if it's taking a lot of time we could just simply disable it. |
LionelJouin
force-pushed
the
go120
branch
2 times, most recently
from
0adba31 to
3064f50
Compare
|
@denis-tingaikin I fixed the issue I had locally, but still a problem in the CI |
|
@LionelJouin Could you check ur local linter version with https://github.com/networkservicemesh/.github/blob/main/.github/workflows/golangci-lint.yaml? |
|
Thank you @denis-tingaikin, I tried locally with v1.49.0 and it failed, so I created a PR on .github to update the version: networkservicemesh/.github#33 |
Signed-off-by: Lionel Jouin <lionel.jouin@est.tech>
|
Now it passes the CI |
denis-tingaikin
approved these changes
Jun 29, 2023
|
@LionelJouin Thanks! |
nsmbot
pushed a commit
to networkservicemesh/sdk-sriov
that referenced
this pull request
Jun 29, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#591 Commit: 183caaa Author: Denis Tingaikin Date: 2023-06-29 16:31:16 +0300 Message: - Merge pull request #591 from Nordix/go120 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-l7-proxy
that referenced
this pull request
Jun 29, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#591 Commit: 183caaa Author: Denis Tingaikin Date: 2023-06-29 16:31:16 +0300 Message: - Merge pull request #591 from Nordix/go120 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Jun 29, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#591 Commit: 183caaa Author: Denis Tingaikin Date: 2023-06-29 16:31:16 +0300 Message: - Merge pull request #591 from Nordix/go120 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
networkservicemesh/deployments-k8s#9216