Use livelinesschecker in non-privileged mode #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
denis-tingaikin
approved these changes
Jun 19, 2023
| } | ||
| defer func() { _ = targetNetNS.Close() }() | ||
|
|
||
| pingGroupRangeFilename := "/proc/sys/net/ipv4/ping_group_range" |
| // See https://github.com/go-ping/ping#linux | ||
| const groupRange = "0 2147483647" | ||
|
|
||
| func set(ctx context.Context, conn *networkservice.Connection) error { |
There was a problem hiding this comment.
Suggested change
| func set(ctx context.Context, conn *networkservice.Connection) error { | |
| func applyPingGroupRange(ctx context, mech *networkservice.Mechanism) error |
| const groupRange = "0 2147483647" | ||
|
|
||
| func set(ctx context.Context, conn *networkservice.Connection) error { | ||
| if mechanism := kernel.ToMechanism(conn.GetMechanism()); mechanism != nil && mechanism.GetVLAN() == 0 { |
There was a problem hiding this comment.
if mechanism := kernel.ToMechanism(conn.GetMechanism()); mechanism != nil && mechanism.GetVLAN() == 0 {Could be used before using applyPingGroupRange(ctx, mech).
This might improve readability because now the function 'set' is doing two things:
- set ping group range
- check mech.
So with applying the suggestion the function will do only:
- set ping group range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: networkservicemesh/deployments-k8s#9218
Description
We use ping to check the liveliness of the connection. In order not to use the root privileges, we need to set the
/proc/sys/net/ipv4/ping_group_rangevalue. It allows to create theSOCK_DGRAMsocket type (instead ofSOCK_RAW) for ping and thus use it in non-privileged mode.