use metadata map for storing vfconfig #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bolodya1997
reviewed
Aug 4, 2021
| // LoadOrStore returns the existing VFConfig stored in per Connection.Id metadata if present. | ||
| // Otherwise, it stores and returns the given nterface_types.InterfaceIndex. | ||
| // The loaded result is true if the value was loaded, false if stored. | ||
| func LoadOrStore(ctx context.Context, isClient bool, config VFConfig) (value VFConfig, ok bool) { |
There was a problem hiding this comment.
Please return *VFConfig instead of VFConfig, I suppose that the most common usage for altering the data would be:
vfConfig, _ := vfconfig.LoadOrStore(ctx, ...)
...
vfConfig.xxx = yyyThere was a problem hiding this comment.
So actually I have meant replacing all VFConfig with *VFConfig, both for input and for output values :)
It should be really confusing if Load and LoadOrStore return different types or if input and output parameters for LoadOrStore have different types.
Bolodya1997
approved these changes
Aug 5, 2021
This was referenced Aug 6, 2021
pperiyasamy
force-pushed
the
metadata-vfconfig
branch
2 times, most recently
from
3fa866a to
2ce3b47
Compare
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
pperiyasamy
force-pushed
the
metadata-vfconfig
branch
from
2ce3b47 to
fc9c8b6
Compare
denis-tingaikin
approved these changes
Aug 29, 2021
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Aug 29, 2021
…k-kernel@main PR link: networkservicemesh/sdk-kernel#307 Commit: eba0791 Author: Denis Tingaikin Date: 2021-08-29 23:55:39 +0300 Message: - Merge pull request #307 from Nordix/metadata-vfconfig Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-sriov
that referenced
this pull request
Aug 29, 2021
…k-kernel@main PR link: networkservicemesh/sdk-kernel#307 Commit: eba0791 Author: Denis Tingaikin Date: 2021-08-29 23:55:39 +0300 Message: - Merge pull request #307 from Nordix/metadata-vfconfig Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stores vfconfig into metadata map service to accommodate vfconfig for both client and endpoint connections.
an alternate and proper fix as per feedback in the PR
Signed-off-by: Periyasamy Palanisamy periyasamy.palanisamy@est.tech