Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issues #24

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Fix CI issues #24

merged 2 commits into from
Oct 1, 2020

Conversation

Bolodya1997
Copy link

@Bolodya1997 Bolodya1997 commented Oct 1, 2020

Update PRs are not getting auto merged, because there is no CI auto merge action.
✓ Added

Some CI checks, test runs are disabled / not added in ci.yaml.
✓ Enabled
✓ Added

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@Bolodya1997 Bolodya1997 marked this pull request as ready for review October 1, 2020 05:52
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add simplifications from sdk repo?

run: |
grep -v 'replace github.com/satori/go.uuid' go.mod | grep ^replace || exit 0
exit 1
captureRunEnv:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is outdated

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@haiodo haiodo merged commit 1639c94 into networkservicemesh:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants