Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit chains to enable rerequest #22

Merged
merged 15 commits into from
Oct 14, 2020
Merged

Edit chains to enable rerequest #22

merged 15 commits into from
Oct 14, 2020

Conversation

Bolodya1997
Copy link

@Bolodya1997 Bolodya1997 commented Sep 20, 2020 •
edited
Loading

  • rename, ipcontext, PF ethernetcontext on rerequest should be executed in clients net NS
    • add netns chain element to switch net NS for all subsequent chain elements
    • remove PF ethernetcontext from ethernetcontext - we don't actually need it now
    • move VF ethernetcontext, ipcontext out of connectioncontext
  • ipcontext shouldn not fail on readding same neighbors/routes on rerequest
    • fix it

@Bolodya1997 Bolodya1997 marked this pull request as draft September 23, 2020 06:59
@Bolodya1997 Bolodya1997 marked this pull request as ready for review September 24, 2020 00:45
haiodo
haiodo reviewed Sep 24, 2020
View reviewed changes
pkg/kernel/link.go Outdated Show resolved Hide resolved
@Bolodya1997 Bolodya1997 marked this pull request as draft September 25, 2020 15:50
@Bolodya1997 Bolodya1997 marked this pull request as ready for review September 25, 2020 17:01
@Bolodya1997 Bolodya1997 force-pushed the connection-context branch 5 times, most recently from d9ebbb6 to 792bf84 Compare October 5, 2020 05:51
Vladimir Popov added 12 commits October 13, 2020 14:26
Add netns server chain element
1dd6ec8 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Don't fail if route/neoghbir already exists
bf26e16 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Rework inject, netns servers using netNSURL instead of netNSInode
8b0742a 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Don't try to set MAC address if it is not set in the EthernetContext
4639b55 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Remove Lock()/Unlock() from NSSwitch
bc17d8a 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Add comments for linux-specific constants
6798a2d 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Add constants file
bf4e8b2 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Remove connectioncontext, PF ethernetcontext
9fbb779 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Add OS thread locking for NS switch
403c442 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Add NSSwitch.RunIn(...)
6f40ba3 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Add tests
154aced 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Add nshandle
999ed70 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Move nsswitch methods to nshandle
474bd89 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Vladimir Popov added 2 commits October 14, 2020 15:58
Close net NS handle
7a02d3d 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Fix race condition in tests
4ad7af0 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@haiodo haiodo merged commit 0097b50 into networkservicemesh:master Oct 14, 2020
@Bolodya1997 Bolodya1997 deleted the connection-context branch November 12, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bolodya1997 @haiodo